Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating a patron with a username and an email corresponding to two different invenio user cause unpredictable errors #1467

Closed
jma opened this issue Nov 19, 2020 · 1 comment
Closed

Creating a patron with a username and an email corresponding to two different invenio user cause unpredictable errors #1467

jma opened this issue Nov 19, 2020 · 1 comment
Assignees
@jma
Labels
bug Breaks something but is not blocking effort: important US candidate f: user management p-Medium Medium priority (to be solved within 1-2 years)
Milestone
v1.1.0

Comments

@jma
Copy link
Contributor

jma commented Nov 19, 2020

Describe the bug
When a patron record is created by a librarian the system try to link an existing invenio user account to this patron record. If the username and the email correspond to two different invenio users, the system create the link with only one invenio user account.

To Reproduce
Steps to reproduce the behavior:

  1. Register a new rero user with a username.
  2. Register a second rero user with an email address.
  3. Log in with a librarian.
  4. Create a new patron with the username and email used to register the two previous rero users.
  5. No errors is notified.

Expected behaviour
The librarian should link explicitly a patron to a invenio user account.
@jma jma added effort: important US candidate triage bug Breaks something but is not blocking labels Nov 19, 2020
@iGormilhit iGormilhit changed the title Create a patron with a username and an email corresponding to two different invenio user cause unpredictable errors Creating a patron with a username and an email corresponding to two different invenio user cause unpredictable errors Nov 19, 2020
@iGormilhit iGormilhit added the p-Medium Medium priority (to be solved within 1-2 years) label Nov 19, 2020
@iGormilhit
Copy link

Will be addressed by US 1467.

@iGormilhit iGormilhit modified the milestones: v1.1.0, v1.0.1 Dec 16, 2020
@iGormilhit iGormilhit modified the milestones: v1.0.1, v1.1.0 Jan 28, 2021
@iGormilhit iGormilhit modified the milestones: v1.1.0, v1.2.0 Mar 1, 2021
jma added a commit to jma/rero-ils that referenced this issue Mar 1, 2021
@jma
user: add new fields
377ebb6 
* Replaces the phone field by 4 new home, buisness, mobile, other phone
  fields in the user data model.
* Adds country, gender fields in the user data model.
* Adds 3 invenio-userprofiles configuration to specify the list of
  countries, the default country and the read only fields.
* Makes the barcode repetitive.
* Removes all the user from the patron data model.
* Adds the secound address, the local code, the source fields in the
  patron data model.
* Closes rero#1724, rero#1634, rero#1615, rero#1490, rero#1467, rero#1318, rero#1384.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Mar 1, 2021
@jma
users: add new fields, move fields from the patron
fdf434b 
* Replaces the phone field by home, business, mobile, other phone fields
  in the user data model.
* Adds country and gender fields in the user data model.
* Adds 3 invenio-userprofiles configuration to specify the list of
  countries, the default country and the read only fields.
* Makes the barcode repetitive.
* Removes all user fields from the patron data model.
* Adds the second address, the local code, the source fields in the
  patron data model.
* Closes rero#1724, rero#1634, rero#1615, rero#1490, rero#1467, rero#1318, rero#1384.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma mentioned this issue Mar 1, 2021
Merged
7 tasks
jma added a commit to jma/rero-ils that referenced this issue Mar 1, 2021
@jma
users: add new fields, move fields from the patron
5480e33 
* Replaces the phone field by home, business, mobile, other phone fields
  in the user data model.
* Adds country and gender fields in the user data model.
* Adds 3 invenio-userprofiles configuration to specify the list of
  countries, the default country and the read only fields.
* Makes the barcode repetitive.
* Removes all user fields from the patron data model.
* Adds the second address, the local code, the source fields in the
  patron data model.
* Closes rero#1724, rero#1634, rero#1615, rero#1490, rero#1467, rero#1318, rero#1384, rero#1670.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Mar 1, 2021
@jma
users: add new fields, move fields from the patron
3cc4c88 
* Replaces the phone field by home, business, mobile, other phone fields
  in the user data model.
* Adds country and gender fields in the user data model.
* Adds 3 invenio-userprofiles configuration to specify the list of
  countries, the default country and the read only fields.
* Makes the barcode repetitive.
* Removes all user fields from the patron data model.
* Adds the second address, the local code, the source fields in the
  patron data model.
* Closes rero#1724, rero#1634, rero#1615, rero#1490, rero#1467, rero#1318, rero#1384, rero#1670.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Mar 1, 2021
@jma
users: add new fields, move fields from the patron
702696c 
* Replaces the phone field by home, business, mobile, other phone fields
  in the user data model.
* Adds country and gender fields in the user data model.
* Adds 3 invenio-userprofiles configuration to specify the list of
  countries, the default country and the read only fields.
* Makes the barcode repetitive.
* Removes all user fields from the patron data model.
* Adds the second address, the local code, the source fields in the
  patron data model.
* Closes rero#1724, rero#1634, rero#1615, rero#1490, rero#1467, rero#1318, rero#1384, rero#1670.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma self-assigned this Mar 1, 2021
jma added a commit to jma/rero-ils that referenced this issue Mar 3, 2021
@jma
users: add new fields, move fields from the patron
a9f6dc7 
* Replaces the phone field by home, business, mobile, other phone fields
  in the user data model.
* Adds country and gender fields in the user data model.
* Adds 3 invenio-userprofiles configuration to specify the list of
  countries, the default country and the read only fields.
* Makes the barcode repetitive.
* Removes all user fields from the patron data model.
* Adds the second address, the local code, the source fields in the
  patron data model.
* Closes rero#1724, rero#1634, rero#1615, rero#1490, rero#1467, rero#1318, rero#1384, rero#1670.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Mar 3, 2021
@jma
users: add new fields, move fields from the patron
fb8f162 
* Replaces the phone field by home, business, mobile, other phone fields
  in the user data model.
* Adds country and gender fields in the user data model.
* Adds 3 invenio-userprofiles configuration to specify the list of
  countries, the default country and the read only fields.
* Makes the barcode repetitive.
* Removes all user fields from the patron data model.
* Adds the second address, the local code, the source fields in the
  patron data model.
* Closes rero#1724, rero#1634, rero#1615, rero#1490, rero#1467, rero#1318, rero#1384, rero#1670.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit that referenced this issue Mar 3, 2021
@jma
users: add new fields, move fields from the patron
dd8ef3f 
* Replaces the phone field by home, business, mobile, other phone fields
  in the user data model.
* Adds country and gender fields in the user data model.
* Adds 3 invenio-userprofiles configuration to specify the list of
  countries, the default country and the read only fields.
* Makes the barcode repetitive.
* Removes all user fields from the patron data model.
* Adds the second address, the local code, the source fields in the
  patron data model.
* Closes #1724, #1634, #1615, #1490, #1467, #1318, #1384, #1670.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit that referenced this issue Mar 3, 2021
@jma
users: add new fields, move fields from the patron
30bf6ec 
* Replaces the phone field by home, business, mobile, other phone fields
  in the user data model.
* Adds country and gender fields in the user data model.
* Adds 3 invenio-userprofiles configuration to specify the list of
  countries, the default country and the read only fields.
* Makes the barcode repetitive.
* Removes all user fields from the patron data model.
* Adds the second address, the local code, the source fields in the
  patron data model.
* Closes #1724, #1634, #1615, #1490, #1467, #1318, #1384, #1670.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma closed this as completed Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jma jma

Labels
bug Breaks something but is not blocking effort: important US candidate f: user management p-Medium Medium priority (to be solved within 1-2 years)
Projects
None yet
Milestone
v1.1.0
Development

No branches or pull requests
2 participants
@jma @iGormilhit