Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[] should not be removed from field "responsibilityStatement" #1406

Closed
pronguen opened this issue Nov 5, 2020 · 0 comments · Fixed by #1461
Closed

[] should not be removed from field "responsibilityStatement" #1406

pronguen opened this issue Nov 5, 2020 · 0 comments · Fixed by #1461
Assignees
@reropag
Labels
f: data About data model, importation, transformation, exportation of data, specific for bibliographic data
Milestone
v0.14.1

Comments

@pronguen
Copy link
Contributor

pronguen commented Nov 5, 2020

How it works

To convert to field responsibilityStatement, the characters [] are removed.

Example: https://ilspilot.test.rero.ch/api/documents/1098521 = http://data.rero.ch/01-R006114538/marchtml

How it should works

We should not treat/remove them.

Context

Proposed by pilot libaries

Screenshot

image
@pronguen pronguen added f: data About data model, importation, transformation, exportation of data, specific for bibliographic data triage labels Nov 5, 2020
@iGormilhit iGormilhit removed the triage label Nov 18, 2020
@iGormilhit iGormilhit added this to the v0.14.1 milestone Nov 18, 2020
reropag added a commit to reropag/rero-ils that referenced this issue Nov 18, 2020
@reropag
data: fix responsibilityStatement conversion
e903b21 
In the build_responsibility_data function,
the square brackets [] are no more considered as trailing punctuation to remove.

* Closes rero#1406.

Co-Authored-by: Gianni Pante <gianni.pante@rero.ch>
@reropag reropag mentioned this issue Nov 18, 2020
Merged
6 tasks
reropag added a commit to reropag/rero-ils that referenced this issue Nov 19, 2020
@reropag
data: fix responsibilityStatement conversion
40bb244 
In the build_responsibility_data function, the square brackets [] are no
more considered as trailing punctuation to be removed.

* Closes rero#1406.

Co-Authored-by: Gianni Pante <gianni.pante@rero.ch>
reropag added a commit to reropag/rero-ils that referenced this issue Nov 19, 2020
@reropag
data: fix responsibilityStatement conversion
cf2431d 
In the build_responsibility_data function, the square brackets [] are no
more considered as trailing punctuation to be removed.

* Closes rero#1406.

Co-Authored-by: Gianni Pante <gianni.pante@rero.ch>
@jma jma closed this as completed in #1461 Nov 19, 2020
jma pushed a commit that referenced this issue Nov 19, 2020
@reropag @jma
data: fix responsibilityStatement conversion
8744071 
In the build_responsibility_data function, the square brackets [] are no
more considered as trailing punctuation to be removed.

* Closes #1406.

Co-Authored-by: Gianni Pante <gianni.pante@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reropag reropag

Labels
f: data About data model, importation, transformation, exportation of data, specific for bibliographic data
Projects
None yet
Milestone
v0.14.1
Development

Successfully merging a pull request may close this issue.

data: fix responsibilityStatement conversion reropag/rero-ils
3 participants
@iGormilhit @pronguen @reropag