data: fix responsibilityStatement conversion #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iGormilhit
suggested changes
Nov 19, 2020
BadrAly
approved these changes
Nov 19, 2020
reropag
force-pushed
the
pag-#1790-fix-data_conversion
branch
from
e903b21 to
40bb244
Compare
iGormilhit
approved these changes
Nov 19, 2020
In the build_responsibility_data function, the square brackets [] are no more considered as trailing punctuation to be removed. * Closes rero#1406. Co-Authored-by: Gianni Pante <gianni.pante@rero.ch>
reropag
force-pushed
the
pag-#1790-fix-data_conversion
branch
from
40bb244 to
cf2431d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the build_responsibility_data function, the square brackets [] are no
more considered as trailing punctuation to be removed.
Co-Authored-by: Gianni Pante gianni.pante@rero.ch
Why are you opening this PR?
To fix the issue mentioned above.
Dependencies
My PR depends on the following
rero-ils-ui's PR(s):How to test?
see issue description
Code review check list