Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holdings Editor: vendor field can not be deselected #1451

Closed
BadrAly opened this issue Nov 18, 2020 · 0 comments · Fixed by #1457
Closed

Holdings Editor: vendor field can not be deselected #1451

BadrAly opened this issue Nov 18, 2020 · 0 comments · Fixed by #1457
Assignees
Labels
bug Breaks something but is not blocking f: acquisitions Related to the acquisition module f: editor Concerns editor based on JSON schema AND custom editor f: serials p-Low Low priority
Milestone

Comments

@BadrAly
Copy link

BadrAly commented Nov 18, 2020

In the holdings editor, for the new field vendor.

If a librarian select by error a vendor, s/he can not remove this selection.

We should have a way to save a holdings with no vendor, after selection of a vendor by error.

version v0.14.0

@BadrAly BadrAly added triage bug Breaks something but is not blocking f: acquisitions Related to the acquisition module f: serials labels Nov 18, 2020
@BadrAly BadrAly added this to the v0.14.1 milestone Nov 18, 2020
@zannkukai zannkukai assigned zannkukai and unassigned zannkukai Nov 18, 2020
@BadrAly BadrAly self-assigned this Nov 18, 2020
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Nov 18, 2020
Fixes a problem when the title of the fields
location, circulation category and electronic_location
where displayed twice in the holdings editor.

Fixes a problem when librarian can not deselect the
vendor field in the holdings editor.

* Closes rero#1452
* Closes rero#1451

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Nov 18, 2020
Fixes a problem when the title of the fields
location, circulation category and electronic_location
where displayed twice in the holdings editor.

Fixes a problem when librarian can not deselect the
vendor field in the holdings editor.

* Closes rero#1452
* Closes rero#1451

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Nov 18, 2020
Fixes a problem when the title of the fields
location, circulation category and electronic_location
where displayed twice in the holdings editor.

Fixes a problem when librarian can not deselect the
vendor field in the holdings editor.

* Closes rero#1452
* Closes rero#1451

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Nov 18, 2020
Fixes a problem when the title of the fields
location, circulation category and electronic_location
where displayed twice in the holdings editor.

Fixes a problem when librarian can not deselect the
vendor field in the holdings editor.

* Closes rero#1452
* Closes rero#1451

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Nov 18, 2020
Fixes a problem when the title of the fields
location, circulation category and electronic_location
where displayed twice in the holdings editor.

Fixes a problem when librarian can not deselect the
vendor field in the holdings editor.

* Closes rero#1452
* Closes rero#1451

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
@iGormilhit iGormilhit added f: editor Concerns editor based on JSON schema AND custom editor p-Low Low priority and removed triage labels Nov 19, 2020
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Nov 19, 2020
Fixes a problem when the title of the fields
location, circulation category and electronic_location
where displayed twice in the holdings editor.

Fixes a problem when librarian can not deselect the
vendor field in the holdings editor.

* Closes rero#1452
* Closes rero#1451

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit that referenced this issue Nov 19, 2020
Fixes a problem when the title of the fields
location, circulation category and electronic_location
where displayed twice in the holdings editor.

Fixes a problem when librarian can not deselect the
vendor field in the holdings editor.

* Closes #1452
* Closes #1451

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Breaks something but is not blocking f: acquisitions Related to the acquisition module f: editor Concerns editor based on JSON schema AND custom editor f: serials p-Low Low priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants