Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Holdings Editor: extra titles for the location and circulation_category fields #1452

Closed
BadrAly opened this issue Nov 18, 2020 · 0 comments · Fixed by #1457
Closed

Holdings Editor: extra titles for the location and circulation_category fields #1452

BadrAly opened this issue Nov 18, 2020 · 0 comments · Fixed by #1457
Assignees
@zannkukai @BadrAly
Labels
enhancement Improvement of an existing feature f: acquisitions Related to the acquisition module f: editor Concerns editor based on JSON schema AND custom editor f: serials
Milestone
v0.14.1

Comments

@BadrAly
Copy link

BadrAly commented Nov 18, 2020

In the holdings editor, the two fields location and circulation_category

have the name of the fields displayed twice. Once as name of the field and the other one as URI.
should remove the URI part

version 0.014

Screenshot 2020-11-18 at 08 29 37
@BadrAly BadrAly added triage bug Breaks something but is not blocking f: acquisitions Related to the acquisition module f: serials labels Nov 18, 2020
@BadrAly BadrAly added this to the v0.14.1 milestone Nov 18, 2020
@BadrAly BadrAly self-assigned this Nov 18, 2020
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Nov 18, 2020
holdings: remove extra titles for some fields
c40671d 
Fixes a problem when the title of the fields
location, circulation category and electronic_location
where displayed twice.

* Closes rero#1452

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Nov 18, 2020
holdings: remove extra titles for some fields in editor
25945e3 
Fixes a problem when the title of the fields
location, circulation category and electronic_location
where displayed twice in the holdings editor.

* Closes rero#1452

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
@BadrAly BadrAly mentioned this issue Nov 18, 2020
Merged
6 tasks
@zannkukai zannkukai self-assigned this Nov 18, 2020
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Nov 18, 2020
holdings: remove extra titles for some fields in editor
efdcea1 
Fixes a problem when the title of the fields
location, circulation category and electronic_location
where displayed twice in the holdings editor.

Fixes a problem when librarian can not deselect the
vendor field in the holdings editor.

* Closes rero#1452
* Closes rero#1451

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Nov 18, 2020
holdings: remove extra titles for some fields in editor
6155df3 
Fixes a problem when the title of the fields
location, circulation category and electronic_location
where displayed twice in the holdings editor.

Fixes a problem when librarian can not deselect the
vendor field in the holdings editor.

* Closes rero#1452
* Closes rero#1451

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Nov 18, 2020
holdings: remove extra titles for some fields in editor
cca11c8 
Fixes a problem when the title of the fields
location, circulation category and electronic_location
where displayed twice in the holdings editor.

Fixes a problem when librarian can not deselect the
vendor field in the holdings editor.

* Closes rero#1452
* Closes rero#1451

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Nov 18, 2020
holdings: remove extra titles for some fields in editor
b121d55 
Fixes a problem when the title of the fields
location, circulation category and electronic_location
where displayed twice in the holdings editor.

Fixes a problem when librarian can not deselect the
vendor field in the holdings editor.

* Closes rero#1452
* Closes rero#1451

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Nov 18, 2020
holdings: remove extra titles for some fields in editor
b406e4b 
Fixes a problem when the title of the fields
location, circulation category and electronic_location
where displayed twice in the holdings editor.

Fixes a problem when librarian can not deselect the
vendor field in the holdings editor.

* Closes rero#1452
* Closes rero#1451

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
@iGormilhit iGormilhit added f: editor Concerns editor based on JSON schema AND custom editor enhancement Improvement of an existing feature and removed bug Breaks something but is not blocking triage labels Nov 19, 2020
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Nov 19, 2020
holdings: remove extra titles for some fields in editor
d8c1a49 
Fixes a problem when the title of the fields
location, circulation category and electronic_location
where displayed twice in the holdings editor.

Fixes a problem when librarian can not deselect the
vendor field in the holdings editor.

* Closes rero#1452
* Closes rero#1451

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit that referenced this issue Nov 19, 2020
holdings: remove extra titles for some fields in editor
478aeac 
Fixes a problem when the title of the fields
location, circulation category and electronic_location
where displayed twice in the holdings editor.

Fixes a problem when librarian can not deselect the
vendor field in the holdings editor.

* Closes #1452
* Closes #1451

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

@BadrAly BadrAly

Labels
enhancement Improvement of an existing feature f: acquisitions Related to the acquisition module f: editor Concerns editor based on JSON schema AND custom editor f: serials
Projects
None yet
Milestone
v0.14.1
Development

Successfully merging a pull request may close this issue.

holdings: remove extra titles for some fields in editor BadrAly/rero-ils
3 participants
@iGormilhit @zannkukai @BadrAly