Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing the patron the email in the RERO ID does not sync in the user resource. #1458

Closed
jma opened this issue Nov 18, 2020 · 0 comments · Fixed by #1463
Closed

Changing the patron the email in the RERO ID does not sync in the user resource. #1458

jma opened this issue Nov 18, 2020 · 0 comments · Fixed by #1463
Assignees
@jma
Labels
bug Breaks something but is not blocking f: user management p-Medium Medium priority (to be solved within 1-2 years)
Milestone
v0.14.1

Comments

@jma
Copy link
Contributor

jma commented Nov 18, 2020

Describe the bug
When a patron update his email in the patron RERO ID form, the email is not updated in the librarian patron view.

To Reproduce
Steps to reproduce the behavior:

  1. Log in with a patron with an email.
  2. Go to the RERO ID update information form. Update the email.
  3. Logout
  4. Log in with a librarian, and check the email of the previous patron. The email did not changed.

Expected behavior
The user patron record should be in sync with the patron information profile.
@jma jma added triage bug Breaks something but is not blocking labels Nov 18, 2020
@jma jma added this to the v0.14.1 milestone Nov 18, 2020
@iGormilhit iGormilhit added p-Medium Medium priority (to be solved within 1-2 years) f: user management and removed triage labels Nov 19, 2020
jma added a commit to jma/rero-ils that referenced this issue Nov 19, 2020
@jma
patrons: fix patron creation and modification
1f212b4 
* Fixes a patron creation with an existing user account, closes: rero#1454.
* Fixes user profile email change does not update the patron record,
  closes rero#1458.
* Fixes a required email for a patron creation if the communication
  channel is email, closes rero#1455.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma self-assigned this Nov 19, 2020
jma added a commit to jma/rero-ils that referenced this issue Nov 19, 2020
@jma
patrons: fix patron creation and modification
03e8d83 
* Fixes a patron creation with an existing user account, closes: rero#1454.
* Fixes user profile email change does not update the patron record,
  closes rero#1458.
* Fixes a required email for a patron creation if the communication
  channel is email, closes rero#1455.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Nov 19, 2020
@jma
patrons: fix patron creation and modification
90d22c2 
* Fixes patron creation with an existing user account, closes rero#1454.
* Ensures that when the patron updates his/her email in the RERO ID, the
  modification is synched to the patron record, closes rero#1458.
* Makes the email required if the communication channel is email, closes rero#1455.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma mentioned this issue Nov 19, 2020
Merged
6 tasks
@iGormilhit iGormilhit changed the title Changing the email in the patron RERO ID view does not change it in the user resource Changing the patron the email in the RERO ID does not sync in the user resource. Nov 19, 2020
@jma jma closed this as completed in #1463 Nov 19, 2020
jma added a commit that referenced this issue Nov 19, 2020
@jma
patrons: fix patron creation and modification
747b790 
* Fixes patron creation with an existing user account, closes #1454.
* Ensures that when the patron updates his/her email in the RERO ID, the
  modification is synched to the patron record, closes #1458.
* Makes the email required if the communication channel is email, closes #1455.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
rerowep pushed a commit to rerowep/rero-ils that referenced this issue Nov 20, 2020
@jma @rerowep
patrons: fix patron creation and modification
b94399e 
* Fixes patron creation with an existing user account, closes rero#1454.
* Ensures that when the patron updates his/her email in the RERO ID, the
  modification is synched to the patron record, closes rero#1458.
* Makes the email required if the communication channel is email, closes rero#1455.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jma jma

Labels
bug Breaks something but is not blocking f: user management p-Medium Medium priority (to be solved within 1-2 years)
Projects
None yet
Milestone
v0.14.1
Development

Successfully merging a pull request may close this issue.

patrons: fix patron creation and modification jma/rero-ils
2 participants
@jma @iGormilhit