patrons: fix patron creation and modification #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jma
force-pushed
the
maj-fix-user-without-email
branch
2 times, most recently
from
bc475dd to
8b4e295
Compare
jma
changed the title
jma
force-pushed
the
maj-fix-user-without-email
branch
from
8b4e295 to
377dd44
Compare
jma
force-pushed
the
maj-fix-user-without-email
branch
2 times, most recently
from
7b091c9 to
1f212b4
Compare
lauren-d
approved these changes
Nov 19, 2020
iGormilhit
suggested changes
Nov 19, 2020
There was a problem hiding this comment.
Commit message corrections:
Fixes a patron creation→Fixes patron creationcloses: #1454→closes 1454Fixes user profile email change does not update the patron record→Ensures that when the patron updates his/her email in the RERO ID, the modification is synched to the patron recordFixes a required email for a patron creation if the communication channel is email→Makes the email required if the communication channel is email
jma
force-pushed
the
maj-fix-user-without-email
branch
from
1f212b4 to
03e8d83
Compare
BadrAly
approved these changes
Nov 19, 2020
* Fixes patron creation with an existing user account, closes rero#1454. * Ensures that when the patron updates his/her email in the RERO ID, the modification is synched to the patron record, closes rero#1458. * Makes the email required if the communication channel is email, closes rero#1455. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma
force-pushed
the
maj-fix-user-without-email
branch
from
03e8d83 to
90d22c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modification is synched to the patron record, closes Changing the patron the email in the RERO ID does not sync in the user resource. #1458.
Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch
Why are you opening this PR?
Code review check list