Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading the professional interface with the role editor should display a permission error #1508

Closed
iGormilhit opened this issue Nov 26, 2020 · 0 comments · Fixed by #1520
Closed

Loading the professional interface with the role editor should display a permission error #1508

iGormilhit opened this issue Nov 26, 2020 · 0 comments · Fixed by #1520
Assignees
@Garfield-fr
Labels
bug Breaks something but is not blocking f: permissions Concerns the rights management f: professional ui Professional interface p-Low Low priority

Comments

@iGormilhit
Copy link

iGormilhit commented Nov 26, 2020 •
edited
Loading

Describe the bug

Loading the professional interface with the role editor results in an internal server error. It should display a permission error instead.

To Reproduce

  1. Go to ils.test.rero.ch/professional.
  2. Log in as editor.
  3. See the internal server error.

Expected behavior

The displayed error should be a permission error.

Context

Screenshots

ksnip_20201126-081059
@iGormilhit iGormilhit added f: professional ui Professional interface f: permissions Concerns the rights management bug Breaks something but is not blocking p-Low Low priority labels Nov 26, 2020
@Garfield-fr Garfield-fr self-assigned this Nov 26, 2020
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Nov 27, 2020
@Garfield-fr @zannkukai
menu: allow the librarian to switch library
b7e0dd2 
Enables the librarian to change from one libary to another
if he or she works in several libraries.

* Fixes patron view to display multiple libraries.
* Fix populate of select in the routing system.
* closes rero/rero-ils#1510
* closes rero/rero-ils#1508

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Nov 30, 2020
@Garfield-fr
interface: professional access
9ce27eb 
When a user doesn't have a patron record, we display a message "Permission required".

* Closes rero#1508

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr mentioned this issue Nov 30, 2020
Merged
7 tasks
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Nov 30, 2020
@Garfield-fr
permissions: fix error message for users
368e133 
When a user that doesn't have the patron, librarian or system librarian
role, the message "Permission required" is displayed instead of
"Internal server error".

* Closes rero#1508

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Nov 30, 2020
@Garfield-fr
permissions: fix error message for users
0fc41e8 
When a user that doesn't have the patron, librarian or system librarian
role, the message "Permission required" is displayed instead of
"Internal server error".

* Closes rero#1508

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit that referenced this issue Dec 1, 2020
@Garfield-fr
permissions: fix error message for users
9726ad9 
When a user that doesn't have the patron, librarian or system librarian
role, the message "Permission required" is displayed instead of
"Internal server error".

* Closes #1508

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Garfield-fr Garfield-fr

Labels
bug Breaks something but is not blocking f: permissions Concerns the rights management f: professional ui Professional interface p-Low Low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

permissions: fix error message for users Garfield-fr/rero-ils
2 participants
@Garfield-fr @iGormilhit