Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

permissions: fix error message for users #1520

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr commented Nov 30, 2020

When a user that doesn't have the patron, librarian or system librarian
role, the message "Permission required" is displayed instead of
"Internal server error".

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message proposition:

permissions: fix error message for users 

When a user that doesn't have the patron, librarian or system librarian
role, the message "Permission required" is displayed instead of
"Internal server error".

* Closes #1508

@Garfield-fr Garfield-fr changed the title interface: professional access permissions: fix error message for users Nov 30, 2020
When a user that doesn't have the patron, librarian or system librarian
role, the message "Permission required" is displayed instead of
"Internal server error".

* Closes rero#1508

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr merged commit 9726ad9 into rero:dev Dec 1, 2020
@Garfield-fr Garfield-fr deleted the zub-issue-1508 branch February 17, 2021 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading the professional interface with the role editor should display a permission error
4 participants