Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete a vendor is possible even if holdings are linked to it #1822

Closed
zannkukai opened this issue Apr 12, 2021 · 0 comments · Fixed by #1854
Closed

Delete a vendor is possible even if holdings are linked to it #1822

zannkukai opened this issue Apr 12, 2021 · 0 comments · Fixed by #1854
Assignees
@zannkukai
Labels
bug Breaks something but is not blocking f: acquisitions Related to the acquisition module p-Medium Medium priority (to be solved within 1-2 years)

Comments

@zannkukai
Copy link
Contributor

zannkukai commented Apr 12, 2021 •
edited by iGormilhit
Loading

Describe the bug

It's possible to delete a vendor even if some holdings are linked to it. It shouldn't be possible.
We need to correct the function Vendor.get_links_to_me() into rero_ils.modules.vendor.api.py file.
@zannkukai zannkukai added triage bug Breaks something but is not blocking labels Apr 12, 2021
@iGormilhit iGormilhit changed the title Delete a vendor is possible even if some holdings are linked to it. Delete a vendor is possible even if holdings are linked to it Apr 27, 2021
@iGormilhit iGormilhit added f: acquisitions Related to the acquisition module p-Medium Medium priority (to be solved within 1-2 years) and removed triage labels Apr 27, 2021
@zannkukai zannkukai self-assigned this Apr 28, 2021
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Apr 28, 2021
@zannkukai
Vendor: add holding as reason to not delete
2776404 
Closes rero#1822.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai mentioned this issue Apr 28, 2021
Merged
7 tasks
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Apr 29, 2021
@zannkukai
vendors: restrict deletion
633042f 
* Prevents the deletion of a vendor record when a holdings is attached
  to it.
* Closes rero#1822.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Apr 30, 2021
@zannkukai
vendors: restrict deletion
dc2fceb 
* Prevents the deletion of a vendor record when a holdings is attached
  to it.
* Closes rero#1822.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit that referenced this issue May 4, 2021
@zannkukai
vendors: restrict deletion
f8d1d65 
* Prevents the deletion of a vendor record when a holdings is attached
  to it.
* Closes #1822.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit that referenced this issue May 7, 2021
@zannkukai
vendors: restrict deletion
5986cae 
* Prevents the deletion of a vendor record when a holdings is attached
  to it.
* Closes #1822.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
bug Breaks something but is not blocking f: acquisitions Related to the acquisition module p-Medium Medium priority (to be solved within 1-2 years)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

vendors: restrict deletion zannkukai/rero-ils
2 participants
@iGormilhit @zannkukai