Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendors: restrict deletion #1854

Merged
merged 1 commit into from
May 4, 2021
Merged

vendors: restrict deletion #1854

merged 1 commit into from
May 4, 2021

Conversation

zannkukai
Copy link
Contributor

Closes #1822.

Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@zannkukai zannkukai self-assigned this Apr 28, 2021
@zannkukai zannkukai added the bug Breaks something but is not blocking label Apr 28, 2021
@iGormilhit iGormilhit changed the title Vendor: add holding as reason to not delete vendors: add holding as reason to not delete Apr 29, 2021
@iGormilhit iGormilhit added the f: acquisitions Related to the acquisition module label Apr 29, 2021
iGormilhit
iGormilhit reviewed Apr 29, 2021
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit proposition:

vendors: restrict deletion

* Prevents the deletion of a vendor record when a holdings is attached
  to it.
* Closes rero/rero-ils#1822.

@iGormilhit iGormilhit changed the title vendors: add holding as reason to not delete vendors: restrict deletion Apr 29, 2021
@zannkukai zannkukai force-pushed the zan-fix-issue-1822 branch from 2776404 to 633042f Compare April 29, 2021 14:59
@zannkukai zannkukai requested a review from iGormilhit April 29, 2021 14:59
@zannkukai
vendors: restrict deletion
dc2fceb 
* Prevents the deletion of a vendor record when a holdings is attached
  to it.
* Closes rero#1822.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai force-pushed the zan-fix-issue-1822 branch from 633042f to dc2fceb Compare April 30, 2021 09:32
@zannkukai zannkukai changed the base branch from dev to 1.3.0 May 4, 2021 11:26
@zannkukai zannkukai merged commit f8d1d65 into rero:1.3.0 May 4, 2021
@zannkukai zannkukai deleted the zan-fix-issue-1822 branch May 4, 2021 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauren-d lauren-d lauren-d approved these changes

@rerowep rerowep rerowep approved these changes

@benerken benerken benerken approved these changes

@BadrAly BadrAly Awaiting requested review from BadrAly

@iGormilhit iGormilhit Awaiting requested review from iGormilhit

Assignees

@zannkukai zannkukai

Labels
bug Breaks something but is not blocking f: acquisitions Related to the acquisition module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete a vendor is possible even if holdings are linked to it
5 participants
@zannkukai @iGormilhit @benerken @rerowep @lauren-d