Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation of Circulation policy settings #213

Closed
BadrAly opened this issue Mar 12, 2019 · 0 comments
Closed

Validation of Circulation policy settings #213

BadrAly opened this issue Mar 12, 2019 · 0 comments
Assignees
@AoNoOokami
Labels
developers From a developer point of view. enhancement Improvement of an existing feature

Comments

@BadrAly
Copy link

BadrAly commented Mar 12, 2019

Currently, the only way to validate the cipo.settings is through the form editor.
No control at all is done if you create/update a cipo via API or using the cli records create
The validation is simply to ensure that the pair item_type/patron_type exists in one cipo
@BadrAly BadrAly added the enhancement Improvement of an existing feature label Mar 12, 2019
@iGormilhit iGormilhit added the developers From a developer point of view. label Mar 25, 2019
@AoNoOokami AoNoOokami self-assigned this Nov 20, 2019
@AoNoOokami AoNoOokami mentioned this issue Nov 20, 2019
Merged
7 tasks
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Nov 20, 2019
fix: correct circulation policy
d2c15fc 
* Corrects item types and patron_types of circulation policy with pid = 10 and 11.
* Adds test to check data consistency when ci-po are created.
* Closes rero#626.
* Closes rero#213.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Nov 20, 2019
fix: correct circulation policy
797ee0c 
* Corrects item types and patron_types of circulation policy with pid = 10 and 11.
* Adds test to check data consistency when ci-po are created.
* Adds new patron type.
* Closes rero#626.
* Closes rero#213.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Nov 22, 2019
fix: correct circulation policy
bbdf956 
* Corrects item types and patron_types of circulation policy with pid = 10 and 11.
* Adds test to check data consistency when ci-po are created.
* Adds new patron type.
* Corrects import sorting.
* Closes rero#626.
* Closes rero#213.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Nov 22, 2019
fix: correct circulation policy
3b23791 
* Corrects item types and patron_types of circulation policy with pid = 10 and 11.
* Adds test to check data consistency when ci-po are created.
* Adds new patron type.
* Corrects import sorting.
* Closes rero#626.
* Closes rero#213.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Nov 22, 2019
fix: correct circulation policy
6bf99d5 
* Corrects item types and patron_types of circulation policy with pid = 10 and 11.
* Adds test to check data consistency when ci-po are created.
* Adds new patron type.
* Corrects import sorting.
* Closes rero#626.
* Closes rero#213.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Nov 22, 2019
fix: correct circulation policy
cf9bb07 
* Corrects item types and patron_types of circulation policy with pid = 10 and 11.
* Adds test to check data consistency when ci-po are created.
* Adds new patron type.
* Corrects import sorting.
* Closes rero#625.
* Closes rero#626.
* Closes rero#213.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Nov 22, 2019
fix: correct circulation policy
169a7cb 
* Corrects item types and patron_types of circulation policy with pid = 10 and 11.
* Adds test to check data consistency when ci-po are created.
* Adds new patron type.
* Corrects import sorting.
* Closes rero#625.
* Closes rero#626.
* Closes rero#213.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit that referenced this issue Nov 25, 2019
fix: correct circulation policy
5ef67e3 
* Corrects item types and patron_types of circulation policy with pid = 10 and 11.
* Adds test to check data consistency when ci-po are created.
* Adds new patron type.
* Corrects import sorting.
* Closes #625.
* Closes #626.
* Closes #213.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit that referenced this issue Nov 25, 2019
fix: correct circulation policy
9299f5b 
* Corrects item types and patron_types of circulation policy with pid = 10 and 11.
* Adds test to check data consistency when ci-po are created.
* Adds new patron type.
* Corrects import sorting.
* Closes #625.
* Closes #626.
* Closes #213.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
rerowep pushed a commit that referenced this issue Nov 29, 2019
@rerowep
fix: correct circulation policy
5e06a11 
* Corrects item types and patron_types of circulation policy with pid = 10 and 11.
* Adds test to check data consistency when ci-po are created.
* Adds new patron type.
* Corrects import sorting.
* Closes #625.
* Closes #626.
* Closes #213.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@jma jma closed this as completed in 0e71baa Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AoNoOokami AoNoOokami

Labels
developers From a developer point of view. enhancement Improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iGormilhit @BadrAly @AoNoOokami