fix: correct circulation policy

[AoNoOokami]

• BETTER Corrects item types of circulation policy with pid = 10 and 11.
• NEW Adds new patron type.
• NEW Adds test to check data consistency when ci-po are created.
• Closes Circulation policy custom editor do not load patron types and item types settings #625.
• Closes Irma is not able to open the circulation policy editor #626.
• Closes Validation of Circulation policy settings #213

Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch

Why are you opening this PR?

Some circulation policies have item types and patron types not related to their organisation.

How to test?

Circulation policies create (issue #213):

Run ./scripts/setup -> should proceed as usual with no error
Then change a patron type or an item type of a circulation policy for one that doesn't belong to the correct organisation in : data/circulation_policies.json
Run ./scripts/setup : the script will raise an error and stop.
Run ./scripts/setup -p : the script will raise an error and continue.

Issue #625 :

On rero-ils: open ci-po editor and confirm that patron type and item type settings are loaded.
See also the issue details for more checks.

Issue #626 :

Login as Irma Pince: reroilstest+irma@gmail.com
Open ci-po editor to add or edit a ci-po. Saving new ci-po or modifications doesn't work on rero-ils-ui with proxy, but on rero-ils it's ok.

Code review check list

• Commit message template compliance.
• Commit message without typos.
• File names.
• Functions names.
• Functions docstrings.
• Unnecessary commited files?
• Extracted translations?

[iGormilhit]

This is very cool, cause it solves many issues, IMHO #625 also, as I have checked. Could you verify this?

If this is the case, it could be nice to be merged into master, or into a specific branch to be deployed on ils.test for the next workshop.

[AoNoOokami]

This is very cool, cause it solves many issues, IMHO #625 also, as I have checked. Could you verify this?

If this is the case, it could be nice to be merged into master, or into a specific branch to be deployed on ils.test for the next workshop.

I checked that. Unfortunately, it doesn't fix this issue, which is related to the editor form and not to the brief or detailed view. Actually, I wasn't able to save a new circulation policy. I also saw that cancelling the add or edit generates errors in the console, even if the ui does what is expected. So this form really needs to be reviewed.

EDIT: Actually, I tested it on rero-ils-ui. There are some issues there, but I was able to create a new ci-po on rero-ils with expected saving of settings. Those settings were not available anymore for another ci-po creation, as expected. I will add Closes #625 to the commit message.