Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing translations in the holdings detail view #2276

Closed
JoelleDosimont opened this issue Aug 6, 2021 · 1 comment · Fixed by rero/rero-ils-ui#845
Closed

Missing translations in the holdings detail view #2276

JoelleDosimont opened this issue Aug 6, 2021 · 1 comment · Fixed by rero/rero-ils-ui#845
Assignees
@PascalRepond
Labels
bug Breaks something but is not blocking f: serials p-Low Low priority translations Translations

Comments

@JoelleDosimont
Copy link
Contributor

Describe the bug

Some values of the holdings are not translate in the detail view (but are ok in the editor).

To Reproduce

  1. Edit or create a serial holding (ex. : https://ilsdev.test.rero.ch/professional/records/holdings/detail/22747)
  2. Add one of the following fields : Acquisition status, Acquisition method, General retention policy, Completness, Composite copy report
  3. Save the holdings
  4. See that in the detail view, the value for those fields is always in English (but it's ok in the Editor).

Expected behavior

The value should be translated.

Context

Screenshots

image
@JoelleDosimont JoelleDosimont added translations Translations triage bug Breaks something but is not blocking p-Low Low priority f: serials labels Aug 6, 2021
@iGormilhit iGormilhit removed the triage label Aug 25, 2021
@iGormilhit iGormilhit changed the title Translation in the holdings detail view Missing translations in the holdings detail view Aug 25, 2021
@iGormilhit
Copy link

The strings seem to be translated on Weblate: https://hosted.weblate.org/translate/rero_plus/rero-ils/fr/?checksum=ae7911ce16c2f484

PascalRepond added a commit to PascalRepond/rero-ils-ui that referenced this issue Apr 26, 2022
@PascalRepond
translations: fix missing translations
4bdb222 
- Solves rero/rero-ils#2276
- Solves rero/rero-ils#2752

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
@PascalRepond PascalRepond mentioned this issue Apr 26, 2022
Merged
PascalRepond added a commit to PascalRepond/rero-ils-ui that referenced this issue Apr 26, 2022
@PascalRepond
translations: fix missing translations
707013d 
- Solves rero/rero-ils#2276
- Solves rero/rero-ils#2752

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils-ui that referenced this issue Apr 27, 2022
@PascalRepond
translations: fix missing translations
dede9e0 
- Solves rero/rero-ils#2276
- Solves rero/rero-ils#2752

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils-ui that referenced this issue Apr 27, 2022
@PascalRepond
translations: fix missing translations
5ea082e 
- Closes rero/rero-ils#2276
- Closes rero/rero-ils#2752

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils-ui that referenced this issue Apr 27, 2022
@PascalRepond
translations: fix missing translations
c20f614 
- Closes rero/rero-ils#2276
- Closes rero/rero-ils#2752

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
zannkukai pushed a commit to rero/rero-ils-ui that referenced this issue Apr 27, 2022
@PascalRepond @zannkukai
translations: fix missing translations
e911f88 
- Closes rero/rero-ils#2276
- Closes rero/rero-ils#2752

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils-ui that referenced this issue Apr 28, 2022
@PascalRepond
translations: fix missing translations
3af6d42 
- Closes rero/rero-ils#2276
- Closes rero/rero-ils#2752

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils-ui that referenced this issue Apr 29, 2022
@PascalRepond
translations: fix missing translations
248b9dd 
- Closes rero/rero-ils#2276
- Closes rero/rero-ils#2752

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils-ui that referenced this issue Apr 29, 2022
@PascalRepond
translations: fix missing translations
7f47106 
- Closes rero/rero-ils#2276
- Closes rero/rero-ils#2752

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils-ui that referenced this issue Apr 29, 2022
@PascalRepond
translations: fix missing translations
be96fb6 
- Closes rero/rero-ils#2276
- Closes rero/rero-ils#2752

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils-ui that referenced this issue Apr 29, 2022
@PascalRepond
translations: fix missing translations
df4a5e5 
- Closes rero/rero-ils#2276
- Closes rero/rero-ils#2752

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to rero/rero-ils-ui that referenced this issue Apr 29, 2022
@PascalRepond
translations: fix missing translations
8047f78 
- Closes rero/rero-ils#2276
- Closes rero/rero-ils#2752

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
@PascalRepond PascalRepond self-assigned this May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PascalRepond PascalRepond

Labels
bug Breaks something but is not blocking f: serials p-Low Low priority translations Translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

translations: fix missing translations PascalRepond/rero-ils-ui
4 participants
@iGormilhit @pronguen @PascalRepond @JoelleDosimont