Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"1 request" is not translated in the professional document detailed view #2752

Closed
pronguen opened this issue Mar 9, 2022 · 0 comments · Fixed by rero/rero-ils-ui#845
Closed

"1 request" is not translated in the professional document detailed view #2752

pronguen opened this issue Mar 9, 2022 · 0 comments · Fixed by rero/rero-ils-ui#845
Assignees
@PascalRepond
Labels
bug Breaks something but is not blocking effort: minor Solved quickly f: professional ui Professional interface p-Low Low priority translations Translations

Comments

@pronguen
Copy link
Contributor

pronguen commented Mar 9, 2022

Bug description:

"1 request" is not translated in the professional document detailed view, for an item that has requests, and there is a space between this indication and the rest of the loan status. See screenshot.

Expected behavior:

  • Is translated
  • Has no whitespace with the rest of the loan status

Steps to Reproduce:

Server:

Version:

v1.9.0

Screenshots

image
@pronguen pronguen added bug Breaks something but is not blocking p-Low Low priority translations Translations f: professional ui Professional interface effort: minor Solved quickly labels Mar 9, 2022
PascalRepond added a commit to PascalRepond/rero-ils-ui that referenced this issue Apr 26, 2022
@PascalRepond
translations: fix missing translations
4bdb222 
- Solves rero/rero-ils#2276
- Solves rero/rero-ils#2752

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
@PascalRepond PascalRepond mentioned this issue Apr 26, 2022
Merged
PascalRepond added a commit to PascalRepond/rero-ils-ui that referenced this issue Apr 26, 2022
@PascalRepond
translations: fix missing translations
707013d 
- Solves rero/rero-ils#2276
- Solves rero/rero-ils#2752

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils-ui that referenced this issue Apr 27, 2022
@PascalRepond
translations: fix missing translations
dede9e0 
- Solves rero/rero-ils#2276
- Solves rero/rero-ils#2752

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils-ui that referenced this issue Apr 27, 2022
@PascalRepond
translations: fix missing translations
5ea082e 
- Closes rero/rero-ils#2276
- Closes rero/rero-ils#2752

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils-ui that referenced this issue Apr 27, 2022
@PascalRepond
translations: fix missing translations
c20f614 
- Closes rero/rero-ils#2276
- Closes rero/rero-ils#2752

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
zannkukai pushed a commit to rero/rero-ils-ui that referenced this issue Apr 27, 2022
@PascalRepond @zannkukai
translations: fix missing translations
e911f88 
- Closes rero/rero-ils#2276
- Closes rero/rero-ils#2752

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils-ui that referenced this issue Apr 28, 2022
@PascalRepond
translations: fix missing translations
3af6d42 
- Closes rero/rero-ils#2276
- Closes rero/rero-ils#2752

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils-ui that referenced this issue Apr 29, 2022
@PascalRepond
translations: fix missing translations
248b9dd 
- Closes rero/rero-ils#2276
- Closes rero/rero-ils#2752

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils-ui that referenced this issue Apr 29, 2022
@PascalRepond
translations: fix missing translations
7f47106 
- Closes rero/rero-ils#2276
- Closes rero/rero-ils#2752

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils-ui that referenced this issue Apr 29, 2022
@PascalRepond
translations: fix missing translations
be96fb6 
- Closes rero/rero-ils#2276
- Closes rero/rero-ils#2752

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils-ui that referenced this issue Apr 29, 2022
@PascalRepond
translations: fix missing translations
df4a5e5 
- Closes rero/rero-ils#2276
- Closes rero/rero-ils#2752

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to rero/rero-ils-ui that referenced this issue Apr 29, 2022
@PascalRepond
translations: fix missing translations
8047f78 
- Closes rero/rero-ils#2276
- Closes rero/rero-ils#2752

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
@PascalRepond PascalRepond self-assigned this May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PascalRepond PascalRepond

Labels
bug Breaks something but is not blocking effort: minor Solved quickly f: professional ui Professional interface p-Low Low priority translations Translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

translations: fix missing translations PascalRepond/rero-ils-ui
2 participants
@pronguen @PascalRepond