Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document editor problems with place of publication (provisionActivity) #2659

Closed
pronguen opened this issue Jan 27, 2022 · 0 comments · Fixed by #2753
Closed

Document editor problems with place of publication (provisionActivity) #2659

pronguen opened this issue Jan 27, 2022 · 0 comments · Fixed by #2753
Labels
bug Breaks something but is not blocking correction An implemented feature doesn't work as expected. f: editor Concerns editor based on JSON schema AND custom editor p-Medium Medium priority (to be solved within 1-2 years)

Comments

@pronguen
Copy link
Contributor

Describe the bug

  1. Field provisionActivity.place.identifiedBy is not displayed in the editor (see this example and screenshot).
  2. Field provisionActivity.place.$ref is displayed by default in the editor, but should be hidden by default.

To Reproduce

See example

Expected behavior

  1. If field provisionActivity.place.identifiedBy exists in the data, it is displayed in the editor
  2. Field provisionActivity.place.$ref is not displayed by default in the editor (except if it exists in the data)

Context

  • server: bib.rero.ch
  • version: v1.8.0

Screenshots

image
@pronguen pronguen added f: editor Concerns editor based on JSON schema AND custom editor bug Breaks something but is not blocking correction p-Medium Medium priority (to be solved within 1-2 years) labels Jan 27, 2022
@PascalRepond PascalRepond added the correction An implemented feature doesn't work as expected. label Mar 15, 2022
@pronguen pronguen mentioned this issue Mar 16, 2022
Closed
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue May 11, 2022
@Garfield-fr
documents: add identifiedBy on some fields.
5fcd754 
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes rero#2275.
* Closes rero#2388.
* Closes rero#2766.
* Closes rero#2659.
* Closes rero#2649.
* Closes rero#2625.
* Closes rero#2340.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr mentioned this issue May 11, 2022
Merged
7 tasks
Garfield-fr added a commit that referenced this issue May 12, 2022
@Garfield-fr
documents: add identifiedBy on some fields.
d158e5c 
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes #2275.
* Closes #2388.
* Closes #2766.
* Closes #2659.
* Closes #2649.
* Closes #2625.
* Closes #2340.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 7, 2022
@Garfield-fr
documents: add identifiedBy on some fields.
457f0a7 
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes rero#2275.
* Closes rero#2388.
* Closes rero#2766.
* Closes rero#2659.
* Closes rero#2649.
* Closes rero#2625.
* Closes rero#2340.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 7, 2022
@Garfield-fr
documents: add identifiedBy on some fields.
ab63f9b 
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes rero#2275.
* Closes rero#2388.
* Closes rero#2766.
* Closes rero#2659.
* Closes rero#2649.
* Closes rero#2625.
* Closes rero#2340.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 8, 2022
@Garfield-fr
documents: add identifiedBy on some fields.
7a6d169 
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes rero#2275.
* Closes rero#2388.
* Closes rero#2766.
* Closes rero#2659.
* Closes rero#2649.
* Closes rero#2625.
* Closes rero#2340.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 8, 2022
@Garfield-fr
documents: add identifiedBy on some fields.
97720cd 
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes rero#2275.
* Closes rero#2388.
* Closes rero#2766.
* Closes rero#2659.
* Closes rero#2649.
* Closes rero#2625.
* Closes rero#2340.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 8, 2022
@Garfield-fr
documents: add identifiedBy on some fields.
dff603d 
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes rero#2275.
* Closes rero#2388.
* Closes rero#2766.
* Closes rero#2659.
* Closes rero#2649.
* Closes rero#2625.
* Closes rero#2340.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 8, 2022
@Garfield-fr
documents: add identifiedBy on some fields
aae2699 
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes rero#2275.
* Closes rero#2388.
* Closes rero#2766.
* Closes rero#2659.
* Closes rero#2649.
* Closes rero#2625.
* Closes rero#2340.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 9, 2022
@Garfield-fr
documents: add identifiedBy on some fields
39f232f 
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes rero#2275.
* Closes rero#2388.
* Closes rero#2766.
* Closes rero#2659.
* Closes rero#2649.
* Closes rero#2625.
* Closes rero#2340.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit that referenced this issue Jun 9, 2022
@Garfield-fr
documents: add identifiedBy on some fields
2be3812 
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes #2275.
* Closes #2388.
* Closes #2766.
* Closes #2659.
* Closes #2649.
* Closes #2625.
* Closes #2340.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 13, 2022
@Garfield-fr
documents: add identifiedBy on some fields
a79d09b 
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes rero#2275.
* Closes rero#2388.
* Closes rero#2766.
* Closes rero#2659.
* Closes rero#2649.
* Closes rero#2625.
* Closes rero#2340.
* Closes rero#1924.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 13, 2022
@Garfield-fr
documents: add identifiedBy on some fields
8b7f961 
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes rero#2275.
* Closes rero#2388.
* Closes rero#2766.
* Closes rero#2659.
* Closes rero#2649.
* Closes rero#2625.
* Closes rero#2340.
* Closes rero#1924.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 13, 2022
@Garfield-fr
documents: add identifiedBy on some fields
304d657 
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes rero#2275.
* Closes rero#2388.
* Closes rero#2766.
* Closes rero#2659.
* Closes rero#2649.
* Closes rero#2625.
* Closes rero#2340.
* Closes rero#1924.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 13, 2022
@Garfield-fr
documents: add identifiedBy on some fields
1d04fff 
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes rero#2275.
* Closes rero#2388.
* Closes rero#2766.
* Closes rero#2659.
* Closes rero#2649.
* Closes rero#2625.
* Closes rero#2340.
* Closes rero#1924.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 13, 2022
@Garfield-fr
documents: add identifiedBy on some fields
8056f05 
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes rero#2275.
* Closes rero#2388.
* Closes rero#2766.
* Closes rero#2659.
* Closes rero#2649.
* Closes rero#2625.
* Closes rero#2340.
* Closes rero#1924.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit that referenced this issue Jun 13, 2022
@Garfield-fr
documents: add identifiedBy on some fields
4b3644a 
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes #2275.
* Closes #2388.
* Closes #2766.
* Closes #2659.
* Closes #2649.
* Closes #2625.
* Closes #2340.
* Closes #1924.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 14, 2022
@Garfield-fr
documents: add identifiedBy on some fields
86864f8 
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes rero#2275.
* Closes rero#2388.
* Closes rero#2766.
* Closes rero#2659.
* Closes rero#2649.
* Closes rero#2625.
* Closes rero#2340.
* Closes rero#1924.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 14, 2022
@Garfield-fr
documents: add identifiedBy on some fields
68c137d 
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes rero#2275.
* Closes rero#2388.
* Closes rero#2766.
* Closes rero#2659.
* Closes rero#2649.
* Closes rero#2340.
* Closes rero#1924.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 14, 2022
@Garfield-fr
documents: add identifiedBy on some fields
ad778bc 
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes rero#2275.
* Closes rero#2388.
* Closes rero#2766.
* Closes rero#2659.
* Closes rero#2649.
* Closes rero#2340.
* Closes rero#1924.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit that referenced this issue Jun 21, 2022
@Garfield-fr
documents: add identifiedBy on some fields
e1c8906 
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes #2275.
* Closes #2388.
* Closes #2766.
* Closes #2659.
* Closes #2649.
* Closes #2340.
* Closes #1924.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Breaks something but is not blocking correction An implemented feature doesn't work as expected. f: editor Concerns editor based on JSON schema AND custom editor p-Medium Medium priority (to be solved within 1-2 years)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

documents: add identifiedBy on some fields Garfield-fr/rero-ils
2 participants
@pronguen @PascalRepond