Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cataloging editor : contributor and subject fields : data deleted and duplicated #2625

Closed
ThierryClavel opened this issue Jan 3, 2022 · 5 comments · Fixed by rero/ng-core#617
Closed

cataloging editor : contributor and subject fields : data deleted and duplicated #2625

ThierryClavel opened this issue Jan 3, 2022 · 5 comments · Fixed by rero/ng-core#617
Labels
bug Breaks something but is not blocking client request Issue reported by production libraries f: editor Concerns editor based on JSON schema AND custom editor

Comments

@ThierryClavel
Copy link

Describe the bug

When adding a contributor or subject field by "duplicate button", an existing contributor is deleted and another is duplicated.

To Reproduce
exemple https://bib.rero.ch/professional/records/documents/edit/2076666 :
I want to add a new contributor between Martin, T. J and Chinn, Simon,I click on duplicate icon beside agent Martin, T.J. to add it..
Then one contributor (Chinn Simon) is deleted and another (Chinn Jonathan) is duplicated.

Expected behavior

the new field is simply added

  • server: [bib.rero.ch] [bib..test.rero.ch]

  • browser: Firefox

Screenshots

before adding field:
image

after field is added:
image
@ThierryClavel ThierryClavel added triage bug Breaks something but is not blocking f: editor Concerns editor based on JSON schema AND custom editor labels Jan 3, 2022
@PascalRepond PascalRepond added p-Medium Medium priority (to be solved within 1-2 years) p-High High priority (to be solved in the 2-3 next months) and removed p-Medium Medium priority (to be solved within 1-2 years) labels Feb 11, 2022
@pronguen
Copy link
Contributor

I could not reproduce it on v1.9.0

@PascalRepond
Copy link
Contributor

PascalRepond commented Mar 14, 2022 •
edited
Loading

I can reproduce. Issue is still present in v1.9.0.
Firefox v98.0 (64bits) on Windows

It seems to be a form display problem though. When saving the document, the added contributors are saved correctly.

@pronguen
Copy link
Contributor

@PascalRepond Could you give a document example and the way to reproduce it? Does the problem happen only with local contributors, with duplicating the last of the list, etc.?

@PascalRepond
Copy link
Contributor

PascalRepond commented Mar 14, 2022 •
edited
Loading

Tried with this document : https://bib.test.rero.ch/professional/records/documents/edit/1780608
To reproduce:

  • add a contributor by clicking the duplicate button on any but the last two
  • see that the existing GND and IdRef contributors displayed labels are not correct: the first one after the newly added one has disappeared and the last one appears twice

Seems to only happen for documents with 3 or more contributors.

@PascalRepond PascalRepond added p-Medium Medium priority (to be solved within 1-2 years) and removed p-High High priority (to be solved in the 2-3 next months) labels Mar 14, 2022
@pronguen pronguen mentioned this issue Mar 16, 2022
Closed
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue May 11, 2022
@Garfield-fr
documents: add identifiedBy on some fields.
5fcd754 
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes rero#2275.
* Closes rero#2388.
* Closes rero#2766.
* Closes rero#2659.
* Closes rero#2649.
* Closes rero#2625.
* Closes rero#2340.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr mentioned this issue May 11, 2022
Merged
7 tasks
Garfield-fr added a commit that referenced this issue May 12, 2022
@Garfield-fr
documents: add identifiedBy on some fields.
d158e5c 
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes #2275.
* Closes #2388.
* Closes #2766.
* Closes #2659.
* Closes #2649.
* Closes #2625.
* Closes #2340.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 7, 2022
@Garfield-fr
documents: add identifiedBy on some fields.
457f0a7 
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes rero#2275.
* Closes rero#2388.
* Closes rero#2766.
* Closes rero#2659.
* Closes rero#2649.
* Closes rero#2625.
* Closes rero#2340.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 7, 2022
@Garfield-fr
documents: add identifiedBy on some fields.
ab63f9b 
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes rero#2275.
* Closes rero#2388.
* Closes rero#2766.
* Closes rero#2659.
* Closes rero#2649.
* Closes rero#2625.
* Closes rero#2340.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 8, 2022
@Garfield-fr
documents: add identifiedBy on some fields.
7a6d169 
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes rero#2275.
* Closes rero#2388.
* Closes rero#2766.
* Closes rero#2659.
* Closes rero#2649.
* Closes rero#2625.
* Closes rero#2340.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 8, 2022
@Garfield-fr
documents: add identifiedBy on some fields.
97720cd 
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes rero#2275.
* Closes rero#2388.
* Closes rero#2766.
* Closes rero#2659.
* Closes rero#2649.
* Closes rero#2625.
* Closes rero#2340.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 8, 2022
@Garfield-fr
documents: add identifiedBy on some fields.
dff603d 
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes rero#2275.
* Closes rero#2388.
* Closes rero#2766.
* Closes rero#2659.
* Closes rero#2649.
* Closes rero#2625.
* Closes rero#2340.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 8, 2022
@Garfield-fr
documents: add identifiedBy on some fields
aae2699 
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes rero#2275.
* Closes rero#2388.
* Closes rero#2766.
* Closes rero#2659.
* Closes rero#2649.
* Closes rero#2625.
* Closes rero#2340.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 9, 2022
@Garfield-fr
documents: add identifiedBy on some fields
39f232f 
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes rero#2275.
* Closes rero#2388.
* Closes rero#2766.
* Closes rero#2659.
* Closes rero#2649.
* Closes rero#2625.
* Closes rero#2340.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit that referenced this issue Jun 9, 2022
@Garfield-fr
documents: add identifiedBy on some fields
2be3812 
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes #2275.
* Closes #2388.
* Closes #2766.
* Closes #2659.
* Closes #2649.
* Closes #2625.
* Closes #2340.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 13, 2022
@Garfield-fr
documents: add identifiedBy on some fields
a79d09b 
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes rero#2275.
* Closes rero#2388.
* Closes rero#2766.
* Closes rero#2659.
* Closes rero#2649.
* Closes rero#2625.
* Closes rero#2340.
* Closes rero#1924.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 13, 2022
@Garfield-fr
documents: add identifiedBy on some fields
8b7f961 
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes rero#2275.
* Closes rero#2388.
* Closes rero#2766.
* Closes rero#2659.
* Closes rero#2649.
* Closes rero#2625.
* Closes rero#2340.
* Closes rero#1924.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 13, 2022
@Garfield-fr
documents: add identifiedBy on some fields
304d657 
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes rero#2275.
* Closes rero#2388.
* Closes rero#2766.
* Closes rero#2659.
* Closes rero#2649.
* Closes rero#2625.
* Closes rero#2340.
* Closes rero#1924.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 13, 2022
@Garfield-fr
documents: add identifiedBy on some fields
1d04fff 
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes rero#2275.
* Closes rero#2388.
* Closes rero#2766.
* Closes rero#2659.
* Closes rero#2649.
* Closes rero#2625.
* Closes rero#2340.
* Closes rero#1924.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 13, 2022
@Garfield-fr
documents: add identifiedBy on some fields
8056f05 
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes rero#2275.
* Closes rero#2388.
* Closes rero#2766.
* Closes rero#2659.
* Closes rero#2649.
* Closes rero#2625.
* Closes rero#2340.
* Closes rero#1924.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@pronguen pronguen added p-High High priority (to be solved in the 2-3 next months) and removed p-Medium Medium priority (to be solved within 1-2 years) labels Jun 13, 2022
@PascalRepond PascalRepond added the client request Issue reported by production libraries label Jun 13, 2022
Garfield-fr added a commit that referenced this issue Jun 13, 2022
@Garfield-fr
documents: add identifiedBy on some fields
4b3644a 
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes #2275.
* Closes #2388.
* Closes #2766.
* Closes #2659.
* Closes #2649.
* Closes #2625.
* Closes #2340.
* Closes #1924.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 14, 2022
@Garfield-fr
documents: add identifiedBy on some fields
86864f8 
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes rero#2275.
* Closes rero#2388.
* Closes rero#2766.
* Closes rero#2659.
* Closes rero#2649.
* Closes rero#2625.
* Closes rero#2340.
* Closes rero#1924.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@PascalRepond PascalRepond added p-Medium Medium priority (to be solved within 1-2 years) and removed p-High High priority (to be solved in the 2-3 next months) labels Jun 20, 2022
@PascalRepond PascalRepond removed the p-Medium Medium priority (to be solved within 1-2 years) label Mar 30, 2023
@PascalRepond PascalRepond moved this to Project Backlog in RERO ILS issues Mar 30, 2023
@PascalRepond PascalRepond moved this from Product Backlog to Inbox in RERO ILS issues May 22, 2023
@PascalRepond PascalRepond moved this from Inbox to Product Backlog in RERO ILS issues May 22, 2023
@PascalRepond

This comment was marked as outdated.

Sign in to view
@PascalRepond PascalRepond mentioned this issue May 6, 2024
Closed
@PascalRepond PascalRepond mentioned this issue May 14, 2024
Merged
@PascalRepond PascalRepond moved this from Product Backlog to Approved in RERO ILS issues May 15, 2024
@github-project-automation github-project-automation bot moved this from Approved to Done in RERO ILS issues May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Breaks something but is not blocking client request Issue reported by production libraries f: editor Concerns editor based on JSON schema AND custom editor
Projects
RERO ILS issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(editor): remote typeahead clear value Garfield-fr/ng-core
3 participants
@pronguen @ThierryClavel @PascalRepond