Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: adding an element to a type array #3661

Closed
Garfield-fr opened this issue May 2, 2024 · 1 comment · Fixed by rero/ng-core#617 or rero/rero-ils-ui#1166
Closed

Editor: adding an element to a type array #3661

Garfield-fr opened this issue May 2, 2024 · 1 comment · Fixed by rero/ng-core#617 or rero/rero-ils-ui#1166
Assignees
@Garfield-fr
Labels
bug Breaks something but is not blocking f: professional ui Professional interface p-High High priority (to be solved in the 2-3 next months)

Comments

@Garfield-fr
Copy link
Contributor

Garfield-fr commented May 2, 2024 •
edited
Loading

Bug description:

In certain situations, when a new element is added, the next element is emptied of this data.

Expected behavior:

When an element is added, it must be inserted into the list, but must not delete data from other elements.

Steps to Reproduce:

  1. Go to documents
  2. Search "flamand" and edit the record
  3. Jump to Subjects
  4. Add a new entry by clicking on the first subject
  5. The next subject after insertion no longer contains any data

Context

  • Versions: 1.22-dev version (Angular 17/ngx-formly 6)
  • Browser: all
@Garfield-fr Garfield-fr added the bug Breaks something but is not blocking label May 2, 2024
@Garfield-fr Garfield-fr added p-High High priority (to be solved in the 2-3 next months) f: professional ui Professional interface labels May 2, 2024
@PascalRepond
Copy link
Contributor

PascalRepond commented May 6, 2024 •
edited
Loading

Similar to #2625 but is more problematic in formly 6

@PascalRepond PascalRepond marked this as a duplicate of #2625 May 6, 2024
@PascalRepond PascalRepond closed this as not planned Won't fix, can't repro, duplicate, stale May 6, 2024
@github-project-automation github-project-automation bot moved this from Inbox to Done in RERO ILS issues May 6, 2024
@PascalRepond PascalRepond reopened this May 6, 2024
@github-project-automation github-project-automation bot moved this from Done to Product Backlog in RERO ILS issues May 6, 2024
@PascalRepond PascalRepond moved this from Product Backlog to Sprint backlog in RERO ILS issues May 6, 2024
Garfield-fr added a commit to Garfield-fr/ng-core that referenced this issue May 7, 2024
@Garfield-fr @jma
fix(editor): incorrect model assignment
5a518a4 
In the case of the array type, the model is not filled
in correctly when a new entry is inserted.

* Closes rero/rero-ils#3661.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariethoz <johnny.mariethoz@rero.ch>
@Garfield-fr Garfield-fr moved this from Sprint backlog to Ready to test in RERO ILS issues May 7, 2024
@Garfield-fr Garfield-fr mentioned this issue May 7, 2024
Closed
Garfield-fr added a commit to rero/ng-core that referenced this issue May 7, 2024
@Garfield-fr @jma
fix(editor): incorrect model assignment
c9a89e4 
In the case of the array type, the model is not filled
in correctly when a new entry is inserted.

* Closes rero/rero-ils#3661.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariethoz <johnny.mariethoz@rero.ch>
@Garfield-fr Garfield-fr moved this from Ready to test to In Development in RERO ILS issues May 8, 2024
Garfield-fr added a commit to Garfield-fr/ng-core that referenced this issue May 13, 2024
@Garfield-fr @jma
fix(remoteTypehead): assign value
dcd6dbe 
* Closes rero/rero-ils#3661.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariethoz <johnny.mariethoz@rero.ch>
Garfield-fr added a commit to Garfield-fr/ng-core that referenced this issue May 13, 2024
@Garfield-fr @jma
fix(remoteTypehead): assign value
b4f7cc8 
* Closes rero/rero-ils#3661.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariethoz <johnny.mariethoz@rero.ch>
@Garfield-fr Garfield-fr mentioned this issue May 13, 2024
Merged
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue May 13, 2024
@Garfield-fr @jma
fix(remoteTypehead): assign value
190734b 
Closes rero/rero-ils#3661.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariethoz <johnny.mariethoz@rero.ch>
@Garfield-fr Garfield-fr mentioned this issue May 13, 2024
Merged
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue May 13, 2024
@Garfield-fr @jma
fix(remoteTypehead): assign value
d0f33a4 
* Closes rero/rero-ils#3661.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariethoz <johnny.mariethoz@rero.ch>
Garfield-fr added a commit to Garfield-fr/ng-core that referenced this issue May 14, 2024
@Garfield-fr @jma
fix(remoteTypehead): clear value
cc3d542 
Deleting a typeahead value had no effect.

* Fixes typeahead value deletion.
* Fixes refresh label value on typeahead after insert.
* Updates dependencies.
* Closes rero/rero-ils#3661.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariethoz <johnny.mariethoz@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue May 14, 2024
@Garfield-fr @jma
fix(remoteTypehead): clear value
1fc5de5 
* Fixes typeahead value deletion.
* Fixes refresh label value on typeahead after insert.
* Updates dependencies.
* Closes rero/rero-ils#3661.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariethoz <johnny.mariethoz@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue May 14, 2024
@Garfield-fr @jma
fix(editor): entity typeahead clear value
69a8fb9 
* Fixes typeahead value deletion.
* Fixes refresh label value on typeahead after insert.
* Updates dependencies.
* Closes rero/rero-ils#3661.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariethoz <johnny.mariethoz@rero.ch>
Garfield-fr added a commit to Garfield-fr/ng-core that referenced this issue May 14, 2024
@Garfield-fr @jma
fix(editor): remote typeahead clear value
97eb8da 
Deleting a typeahead value had no effect.

* Fixes typeahead value deletion.
* Fixes refresh label value on typeahead after insert.
* Updates dependencies.
* Closes rero/rero-ils#3661.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariethoz <johnny.mariethoz@rero.ch>
Garfield-fr added a commit to Garfield-fr/ng-core that referenced this issue May 14, 2024
@Garfield-fr @jma
fix(editor): remote typeahead clear value
37e6801 
Deleting a typeahead value had no effect.

* Fixes typeahead value deletion.
* Fixes refresh label value on typeahead after insert.
* Updates dependencies.
* Closes rero/rero-ils#3661.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue May 14, 2024
@Garfield-fr @jma
fix(editor): entity typeahead clear value
a0c1e95 
* Fixes typeahead value deletion.
* Fixes refresh label value on typeahead after insert.
* Updates dependencies.
* Closes rero/rero-ils#3661.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
Garfield-fr added a commit to rero/rero-ils-ui that referenced this issue May 14, 2024
@Garfield-fr @jma
fix(editor): entity typeahead clear value
50b1a0c 
* Fixes typeahead value deletion.
* Fixes refresh label value on typeahead after insert.
* Updates dependencies.
* Closes rero/rero-ils#3661.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
Garfield-fr added a commit to rero/ng-core that referenced this issue May 14, 2024
@Garfield-fr @jma
fix(editor): remote typeahead clear value
4ae6338 
Deleting a typeahead value had no effect.

* Fixes typeahead value deletion.
* Fixes refresh label value on typeahead after insert.
* Updates dependencies.
* Closes rero/rero-ils#3661.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
@PascalRepond PascalRepond moved this from In Development to Approved in RERO ILS issues May 15, 2024
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue May 15, 2024
@Garfield-fr @jma
fix(editor): entity typeahead clear value
e834ab6 
* Fixes typeahead value deletion.
* Fixes refresh label value on typeahead after insert.
* Updates dependencies.
* Closes rero/rero-ils#3661.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
Garfield-fr added a commit to rero/ng-core that referenced this issue May 15, 2024
@Garfield-fr @jma
fix(editor): remote typeahead clear value
9b54529 
Deleting a typeahead value had no effect.

* Fixes typeahead value deletion.
* Fixes refresh label value on typeahead after insert.
* Updates dependencies.
* Closes rero/rero-ils#3661.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
@github-project-automation github-project-automation bot moved this from Approved to Done in RERO ILS issues May 15, 2024
Garfield-fr added a commit to rero/rero-ils-ui that referenced this issue May 15, 2024
@Garfield-fr @jma
fix(editor): entity typeahead clear value
5c19f32 
* Fixes typeahead value deletion.
* Fixes refresh label value on typeahead after insert.
* Updates dependencies.
* Closes rero/rero-ils#3661.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Garfield-fr Garfield-fr

Labels
bug Breaks something but is not blocking f: professional ui Professional interface p-High High priority (to be solved in the 2-3 next months)
Projects
RERO ILS issues
Archived in project
Milestone
No milestone
2 participants
@Garfield-fr @PascalRepond