Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Non extendable" not translated in notification #571

Closed
pronguen opened this issue Oct 21, 2019 · 0 comments
Closed

"Non extendable" not translated in notification #571

pronguen opened this issue Oct 21, 2019 · 0 comments
Assignees
@zannkukai
Labels
translations Translations

Comments

@pronguen
Copy link
Contributor

pronguen commented Oct 21, 2019 •
edited
Loading

Describe the issue
In the due soon notification, the word "Non extendable" is not translated in the various languages.

To Reproduce

  1. Create a "due soon" notification for a non extendable item and an italian speaking patron.
  2. Or, easier, consult an existing notification on Gmail (20 oct. 2019)

Expected behavior
Expected is a note in FR/DE/IT, for instance "Non prorogabile"

Screenshots
image
@pronguen pronguen added the translations Translations label Oct 21, 2019
@zannkukai zannkukai self-assigned this Nov 6, 2019
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Nov 6, 2019
@zannkukai
notification: fix "not extendable" string in different languages
55eaf95 
* Fixes "not extendable" string into some email template files.
* Closes rero#571.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai mentioned this issue Nov 6, 2019
Merged
6 tasks
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Nov 6, 2019
@zannkukai
notification: fix "not extendable" string in different languages
628e311 
* Fixes "not extendable" string into some email template files.
* Closes rero#571.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit that referenced this issue Nov 8, 2019
@zannkukai
notification: fix "not extendable" string in different languages
6d69b22 
* Fixes "not extendable" string into some email template files.
* Closes #571.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@jma jma closed this as completed in c9780c7 Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
translations Translations
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iGormilhit @pronguen @zannkukai