Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notification: fix "not extendable" string in different languages #597

Merged
merged 1 commit into from
Nov 8, 2019

Conversation

zannkukai
Copy link
Contributor

How to test?

  • run scripts/bootstrap
  • Create a "due soon" notification for a non extendable item and an italian speaking patron.

OR

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

@zannkukai zannkukai requested review from a team November 6, 2019 08:34
* Fixes "not extendable" string into some email template files.
* Closes rero#571.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai force-pushed the ucl-#1122-not-extendable-traduction branch from 55eaf95 to 628e311 Compare November 6, 2019 09:03
@zannkukai zannkukai requested review from AoNoOokami, BadrAly, blankoworld, Garfield-fr, iGormilhit, jma, lauren-d, pronguen, rerowep and sebdeleze and removed request for a team November 6, 2019 09:04
@zannkukai zannkukai merged commit 6d69b22 into rero:dev Nov 8, 2019
@zannkukai zannkukai deleted the ucl-#1122-not-extendable-traduction branch December 12, 2019 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants