Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In transit to: destination not displayed #770

Closed
pronguen opened this issue Feb 19, 2020 · 4 comments
Closed

In transit to: destination not displayed #770

pronguen opened this issue Feb 19, 2020 · 4 comments
Assignees
@zannkukai
Labels
f: circulation Concerns the circulation interface or backend f: professional ui Professional interface
Milestone
v0.6.0

Comments

@pronguen
Copy link
Contributor

Describe the issue
In circulation UI, for a transaction with transit, destination is not displayed: "in transit (to )".

To Reproduce
Case 1: in the checkin form

  1. Go to the checkin form
  2. Do a checkin an on item that is on loan, with a request and a pickup in another library than the checkin library
  3. The item appears in the list with "in transit (to )": no destination is displayed

Case 2: in the patron account

  1. Same procedure: do the same checkin but from a patron account

Expected behavior
Library name should be displayed as destination

Software version
ilsdev + ilspilot
rero-ils version c236bc8
rero-ils-ui version 4fc4656d

Screenshots
dbocnneimccobdif
@pronguen pronguen added this to the v0.6.0 milestone Feb 19, 2020
@iGormilhit iGormilhit added f: circulation Concerns the circulation interface or backend f: professional ui Professional interface labels Feb 19, 2020
@zannkukai
Copy link
Contributor

This problem occured only on 'circulation/checkout' page : the method "getTransitLocationPid()" return null because the item object doesn't have any loan attribute

@zannkukai zannkukai self-assigned this Feb 19, 2020
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Feb 19, 2020
@zannkukai
items: fix automatic checkin return informations
eb3a3e3 
* Fixes automatic_checkin return informations
* Closes rero#770

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai mentioned this issue Feb 19, 2020
Merged
6 tasks
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Feb 19, 2020
@zannkukai
items: fix automatic checkin return informations
8dab3ad 
* Fixes automatic_checkin return informations
* Closes rero#770

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Feb 19, 2020
@zannkukai
items: fix automatic checkin return informations
7c92b33 
* Fixes automatic_checkin return informations
* Closes rero#770

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
iGormilhit pushed a commit that referenced this issue Feb 19, 2020
@zannkukai
items: fix automatic checkin return informations
a522bfa 
* Fixes automatic_checkin return informations
* Closes #770

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@pronguen
Copy link
Contributor Author

The case 1 is not solved. Transit destination is not displayed. (tested on ilsdev, rero-ils version e2fbc6b, rero-ils-ui version 925ffabb)

image

@pronguen
Copy link
Contributor Author

Case 2 in the patron account is not resolved.

Patron account: checkin
image

Item detailed view
image

BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Feb 24, 2020
circulation: fix loan after a checkin of a validated request
728519c 
* Closes rero#770

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
@BadrAly BadrAly mentioned this issue Feb 24, 2020
Merged
6 tasks
@iGormilhit iGormilhit mentioned this issue Feb 24, 2020
Closed
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Feb 24, 2020
circulation: fix loan after a checkin of a validated request
2358d67 
* Closes rero#770

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit that referenced this issue Feb 25, 2020
circulation: fix loan after a checkin of a validated request
2efea7c 
* Closes #770

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Feb 25, 2020
circulation: display pickup location name when transit for pickup
5d37c74 
* Displays pickup location name when the item is in transit for pickup.
* Highlights items with action needed in checkin form.
* Closes rero/rero-ils#770.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Feb 25, 2020
circulation: display pickup location name when transit for pickup
09df092 
* Displays pickup location name when the item is in transit for pickup.
* Highlights items with action needed in checkin form.
* Closes rero/rero-ils#770.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Feb 25, 2020
circulation: display pickup location name when transit for pickup
4044da7 
* Displays pickup location name when the item is in transit for pickup.
* Highlights items with action needed in checkin form.
* Adds flash message when the item has fees.
* Closes rero/rero-ils#770.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Feb 25, 2020
circulation: display pickup location name when transit for pickup
faa252a 
* Displays pickup location name when the item is in transit for pickup.
* Highlights items with action needed in checkin form.
* Adds flash message when the item has fees.
* Closes rero/rero-ils#770.
* Closes rero/rero-ils#783.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@AoNoOokami AoNoOokami mentioned this issue Feb 25, 2020
Merged
7 tasks
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Feb 25, 2020
circulation: display pickup location name when transit for pickup
7d17644 
* Displays pickup location name when the item is in transit for pickup.
* Highlights items with action needed in checkin form.
* Adds flash message when the item has fees.
* Closes rero/rero-ils#770.
* Closes rero/rero-ils#783.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Feb 25, 2020
circulation: display pickup location name when transit for pickup
28411c1 
* Displays pickup location name when the item is in transit for pickup.
* Highlights items with action needed in checkin form.
* Adds flash message when the item has fees.
* Closes rero/rero-ils#770.
* Closes rero/rero-ils#783.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@pronguen
Copy link
Contributor Author

Case still not resolved. It seems to be a difference based on the owning library of the item, where it should not. My tests below.

The requests done (as Simonetta):
image

The checkin done (as Astrid, Bibliothèque du Lycée de la Vallée d'Aoste):
image

Problems:

  • avise1: in transit to Lycée, but Astrid (working at Lycée) just made a checkin so it should be at desk
  • avise2: at desk, but was asked with pickup in Avise
  • lycee1: ok
  • lycee2: ok

BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Feb 26, 2020
circulation: fix some loan scenarios
7b532d0 
* Closes rero#770
* Improves finding a location of an item when in circulation.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
@BadrAly BadrAly mentioned this issue Feb 26, 2020
Merged
6 tasks
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Feb 26, 2020
circulation: fix some loan scenarios
756fe7f 
* Closes rero#770
* Improves finding a location of an item when in circulation.
* Fixes units testing.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Feb 26, 2020
circulation: fix some loan scenarios
69cc935 
* Closes rero#770
* Improves finding a location of an item when in circulation.
* Fixes units testing.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit that referenced this issue Feb 26, 2020
circulation: fix some loan scenarios
511c768 
* Closes #770
* Improves finding a location of an item when in circulation.
* Fixes units testing.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
f: circulation Concerns the circulation interface or backend f: professional ui Professional interface
Projects
None yet
Milestone
v0.6.0
Development

No branches or pull requests
3 participants
@iGormilhit @pronguen @zannkukai