Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circulation: fix some loan scenarios #806

Merged
merged 1 commit into from
Feb 26, 2020
Merged

Conversation

BadrAly
Copy link

@BadrAly BadrAly commented Feb 26, 2020

Co-Authored-by: Aly Badr aly.badr@rero.ch

How to test?

Login as reroilstest+elena@gmail.com [AVISE library]:

  • checkout item1 of the AVISE library to Broglio,Giulia barcode=2050124312
  • checkout item2 of the AVISE library to Broglio,Giulia barcode=2050124312

Login as reroilstest+simonetta@gmail.com:

  • request the item item1 to pickup location AOSTE-LYCEE
  • request the item item2 to pickup location AOSTE-AVISE

Login as reroilstest@gmail.com: [LYCEE library]

  • checkin item1, item status will be AT_DESK
  • checkin item2, item status will be IN_TRANSIT to AOSTE-AVISE

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

rero_ils/modules/items/api.py Outdated Show resolved Hide resolved
tests/api/test_circ_bug.py Outdated Show resolved Hide resolved
* Closes rero#770
* Improves finding a location of an item when in circulation.
* Fixes units testing.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
Copy link
Contributor

@AoNoOokami AoNoOokami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested: working
Screen Shot 2020-02-26 at 14 10 29

@BadrAly BadrAly merged commit 511c768 into rero:dev Feb 26, 2020
@BadrAly BadrAly deleted the baa-fi-issue-#770 branch November 5, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants