Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saving a document with edition responsibility impossible #906

Closed
pronguen opened this issue Apr 7, 2020 · 2 comments · Fixed by #1071
Closed

Saving a document with edition responsibility impossible #906

pronguen opened this issue Apr 7, 2020 · 2 comments · Fixed by #1071
Assignees
@zannkukai
Labels
bug (critical) Blocking issue, should be fixed ASAP f: editor Concerns editor based on JSON schema AND custom editor
Milestone
v0.11.0

Comments

@pronguen
Copy link
Contributor

pronguen commented Apr 7, 2020

Describe the issue
When I edit a document with an edition designation but no edition responsibility, I cannot save it. I have to remove the field for edition responsibility before.

To Reproduce

  1. Open a document without edition designation
  2. Add an edition designation, but no responsibility
  3. Save it
  4. Edit it again
  5. Don't modify anything but try to save

Expected behavior
I can save the document, so

  • Field for edition responsibility is optional
  • Fields "language" for edition designation and responsibility are not opened by default in the editor when I add the field (it makes it easier)

Software version
ils.test.rero.ch (v.0.6.1)

Screenshots
image
@pronguen pronguen added the f: editor Concerns editor based on JSON schema AND custom editor label Apr 7, 2020
@iGormilhit iGormilhit added this to the Issues sprint 30 milestone Apr 21, 2020
@iGormilhit
Copy link

iGormilhit commented Apr 29, 2020 •
edited
Loading

It's not related to this specific field, it's broader than that.

@jma Could you update this issue title accordingly?

@iGormilhit iGormilhit added the bug (critical) Blocking issue, should be fixed ASAP label Jun 18, 2020
@zannkukai
Copy link
Contributor

zannkukai commented Jun 30, 2020 •
edited
Loading

With 23a9cc7, we can test with documents/249

@zannkukai zannkukai self-assigned this Jun 30, 2020
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Jun 30, 2020
@zannkukai
editor: fix edition statement saving problem.
fb2141e 
According to PO, the 'responsibilities' field from document 'edition
statement' should be optional in the editor form. This commit hides this
field (if it's empty) so, now, the user must choose to add this field
(and fill a value). Editing a document without 'responsibilities' is now
allowed by default.

* Closes rero#906

 # the title begins with a verb, imperative mode
component: summarize changes in 50 char or less

* Adds your new feature.
* Fixes an existing issue, may closes #issue.
* Improves and existing feature.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai mentioned this issue Jun 30, 2020
Merged
7 tasks
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Jun 30, 2020
@zannkukai
editor: fix edition statement saving problem.
8b5fa9d 
According to PO, the 'responsibilities' field from document 'edition
statement' should be optional in the editor form. This commit hides this
field (if it's empty) so, now, the user must choose to add this field
(and fill a value). Editing a document without 'responsibilities' is now
allowed by default.

* Closes rero#906

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Jun 30, 2020
@zannkukai
editor: fix edition statement saving problem.
e74adb1 
According to PO, the 'responsibilities' field from document 'edition
statement' should be optional in the editor form. This commit hides this
field (if it's empty) so, now, the user must choose to add this field
(and fill a value). Editing a document without 'responsibilities' is now
allowed by default.

* Closes rero#906

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Jul 2, 2020
@zannkukai
editor: fix edition statement saving problem.
dc20c33 
The 'responsibilities' field from document 'edition statement' should be
optional in the editor form. This commit hides this field (if it's
empty) so, now, the user must choose to add this field (and fill a
value). Editing a document without 'responsibilities' is now allowed by
default.

* Closes rero#906

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Jul 2, 2020
@zannkukai
editor: fix edition statement saving problem.
2c86d28 
The 'responsibilities' field from document 'edition statement' should be
optional in the editor form. This commit hides this field (if it's
empty) so, now, the user must choose to add this field (and fill a
value). Editing a document without 'responsibilities' is now allowed by
default.

* Closes rero#906

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Jul 3, 2020
@zannkukai
editor: fix edition statement saving problem.
bb219d6 
The 'responsibilities' field from document 'edition statement' should be
optional in the editor form. This commit hides this field (if it's
empty) so, now, the user must choose to add this field (and fill a
value). Editing a document without 'responsibilities' is now allowed by
default.

* Closes rero#906

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
benerken pushed a commit that referenced this issue Jul 9, 2020
@zannkukai @benerken
editor: fix edition statement saving problem.
221e4a8 
The 'responsibilities' field from document 'edition statement' should be
optional in the editor form. This commit hides this field (if it's
empty) so, now, the user must choose to add this field (and fill a
value). Editing a document without 'responsibilities' is now allowed by
default.

* Closes #906

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
bug (critical) Blocking issue, should be fixed ASAP f: editor Concerns editor based on JSON schema AND custom editor
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging a pull request may close this issue.

editor: fix edition statement saving problem. zannkukai/rero-ils
3 participants
@iGormilhit @pronguen @zannkukai