Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editor: fix edition statement saving problem. #1071

Merged
merged 1 commit into from
Jul 9, 2020
Merged

editor: fix edition statement saving problem. #1071

merged 1 commit into from
Jul 9, 2020

Conversation

zannkukai
Copy link
Contributor

According to PO, the 'responsibilities' field from document 'edition
statement' should be optional in the editor form. This commit hides this
field (if it's empty) so, now, the user must choose to add this field
(and fill a value). Editing a document without 'responsibilities' is now
allowed by default.

Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com

How to test?

  • Try to edit a document without edition designation (documents/249)
  • The 'responsibilities' field from 'edition statements' array is now hide by default --> you can save without fill any value.
  • Try to edit again the save document. Add a 'responsibilities' and save the document.
  • Try to edit again, the 'responsibilities' field is well displayed and filled with correct data.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@zannkukai zannkukai force-pushed the zan-#1557-saving-document-edition-statements branch from fb2141e to 8b5fa9d Compare June 30, 2020 08:09
@zannkukai zannkukai self-assigned this Jun 30, 2020
@zannkukai zannkukai added this to the v0.11.0 milestone Jun 30, 2020
@zannkukai zannkukai marked this pull request as ready for review June 30, 2020 11:43
@zannkukai zannkukai force-pushed the zan-#1557-saving-document-edition-statements branch from 8b5fa9d to e74adb1 Compare June 30, 2020 14:38
@iGormilhit
Copy link

@zannkukai According to PO, can be removed from the message commit body.

@zannkukai zannkukai force-pushed the zan-#1557-saving-document-edition-statements branch 2 times, most recently from dc20c33 to 2c86d28 Compare July 2, 2020 07:39
@zannkukai
editor: fix edition statement saving problem.
bb219d6 
The 'responsibilities' field from document 'edition statement' should be
optional in the editor form. This commit hides this field (if it's
empty) so, now, the user must choose to add this field (and fill a
value). Editing a document without 'responsibilities' is now allowed by
default.

* Closes rero#906

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai force-pushed the zan-#1557-saving-document-edition-statements branch from 2c86d28 to bb219d6 Compare July 3, 2020 07:58
@benerken benerken merged commit 221e4a8 into rero:dev Jul 9, 2020
@zannkukai zannkukai deleted the zan-#1557-saving-document-edition-statements branch July 19, 2020 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AoNoOokami AoNoOokami AoNoOokami approved these changes

@BadrAly BadrAly BadrAly approved these changes

@benerken benerken benerken approved these changes

@iGormilhit iGormilhit iGormilhit approved these changes

Assignees

@zannkukai zannkukai

Labels
None yet
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.

Saving a document with edition responsibility impossible
5 participants
@zannkukai @iGormilhit @benerken @BadrAly @AoNoOokami