Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send notification "availability" some time after the item is checked in #913

Closed
pronguen opened this issue Apr 9, 2020 · 4 comments · Fixed by #1691
Closed

Send notification "availability" some time after the item is checked in #913

pronguen opened this issue Apr 9, 2020 · 4 comments · Fixed by #1691
Labels
effort: important US candidate f: circulation Concerns the circulation interface or backend f: notifications p-Medium Medium priority (to be solved within 1-2 years)
Milestone
v1.1.0

Comments

@pronguen
Copy link
Contributor

pronguen commented Apr 9, 2020 •
edited
Loading

Describe the issue
The notification "availability" is sent right after the item is "at desk".

To Reproduce

  1. Log in as a librarian of library X
  2. Check out an item for patron A
  3. Add a request on this item for patron B, with pick up location = X
  4. Checkin the item: it becomes "at desk"
  5. The availability notification has been sent directly

Expected behavior
The availability notification is sent 30 minutes after the item is "at desk". (to be confirmed)

Software version
ilspilot (test phase 1)

Additional context
Note from pilot libraries

Par ailleurs, l'avis semble être envoyé très rapidement après la mise à disposition du document. C'est risqué : un problème quelconque pourrait survenir et empêcher la mise à disposition du document (ouvrage nécessitant un travail en interne avant la prochaine mise à disposition). Actuellement, dans ces cas-là on prête dans la journée à une carte de gestion. Mais il peut se passer plusieurs heures entre le retour et le moment où on a le temps de s'occuper du cas. Si l'avis part trop vite, c'est un problème. Actuellement dans Virtua, les avis sont envoyés le jour ouvrable suivant aux premières heures. Cela allonge le délai, mais est plus sûr. A évaluer

Note from Louvain:
Wait one day to send a notification delays the checkouts of highly requested items.
@pronguen pronguen changed the title Send notification "availability" once a day Send notification "availability" some time after the item is checked in Apr 9, 2020
@iGormilhit iGormilhit added the effort: important US candidate label Apr 21, 2020
@iGormilhit
Copy link

@pronguen Should or could this be a user story, as it is some kind of a new feature, or a modified specification?

@pronguen
Copy link
Contributor Author

@iGormilhit Yes eventually. It also depends on the effort. @BadrAly what do you think?

@pronguen
Copy link
Contributor Author

pronguen commented May 7, 2020

@benerken Pilot library Neuchâtel wants a delay of 120 minutes before sending the notification, to be able to detect eventual problem in the physical document in the meantime.
I think 30 minutes could be a good "Swiss compromise" between a lot of time to detect a problem and an immediate notification in case of bestsellers.

@iGormilhit iGormilhit added f: circulation Concerns the circulation interface or backend f: notifications p-Medium Medium priority (to be solved within 1-2 years) labels Nov 26, 2020
@iGormilhit iGormilhit added this to the v1.0.0 milestone Nov 30, 2020
@iGormilhit iGormilhit removed this from the v1.0.0 milestone Dec 16, 2020
@pronguen
Copy link
Contributor Author

pronguen commented Jan 13, 2021 •
edited by iGormilhit
Loading

Will be solved as a configuration in US 1922.

AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Feb 17, 2021
libraries: add notification settings
2107e29 
* Improve library editor appearance for large screens. It doesn't take
the full width anymore.
* Add notifications settings in library custom editor.
* Displays notification settings in library detail view.
* Closes rero/rero-ils#913.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Feb 17, 2021
libraries: add notification settings
abb661f 
* Improve library editor appearance for large screens. It doesn't take
the full width anymore.
* Add notifications settings in library custom editor.
* Displays notification settings in library detail view.
* Closes rero/rero-ils#913.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Feb 17, 2021
libraries: add notification settings
6fd7b2f 
* Improve library editor appearance for large screens. It doesn't take
the full width anymore.
* Add notifications settings in library custom editor.
* Displays notification settings in library detail view.
* Closes rero/rero-ils#913.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@AoNoOokami AoNoOokami mentioned this issue Feb 17, 2021
Merged
7 tasks
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Feb 22, 2021
libraries: add notification settings
791322d 
* Improve library editor appearance for large screens. It doesn't take
the full width anymore.
* Add notifications settings in library custom editor.
* Displays notification settings in library detail view.
* Closes rero/rero-ils#913.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@AoNoOokami AoNoOokami mentioned this issue Feb 23, 2021
Merged
7 tasks
@iGormilhit iGormilhit added this to the v1.2.0 milestone Mar 4, 2021
jma added a commit to AoNoOokami/rero-ils that referenced this issue Mar 15, 2021
@zannkukai @jma
libraries: add notification settings in library definition
97649a7 
* Adds notification settings in library jsonschema and mapping.
* Adds notification settings data.
* For patron with mail communication channel the notification is sent to
  the corresponding library email if it exists.
* Closes rero#913.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
jma added a commit to AoNoOokami/rero-ils that referenced this issue Mar 16, 2021
@zannkukai @jma
libraries: add notification settings in library definition
706c281 
* Adds notification settings in library jsonschema and mapping.
* Adds notification settings data.
* For patron with mail communication channel the notification is sent to
  the corresponding library email if it exists.
* Closes rero#913.
* Adds patron information for each email sent to the library emails.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
jma added a commit to AoNoOokami/rero-ils that referenced this issue Mar 16, 2021
@zannkukai @jma
libraries: add notification settings in library definition
c9287f2 
* Adds notification settings in library jsonschema and mapping.
* Adds notification settings data.
* For patron with mail communication channel the notification is sent to
  the corresponding library email if it exists.
* Closes rero#913.
* Adds patron information for each email sent to the library emails.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
jma added a commit to AoNoOokami/rero-ils that referenced this issue Mar 16, 2021
@zannkukai @jma
libraries: add notification settings in library definition
5827225 
* Adds notification settings in library jsonschema and mapping.
* Adds notification settings data.
* For patron with mail communication channel the notification is sent to
  the corresponding library email if it exists.
* Closes rero#913.
* Adds patron information for each email sent to the library emails.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
@jma jma closed this as completed in #1691 Mar 16, 2021
jma added a commit that referenced this issue Mar 16, 2021
@zannkukai @jma
libraries: add notification settings in library definition
9ad6be9 
* Adds notification settings in library jsonschema and mapping.
* Adds notification settings data.
* For patron with mail communication channel the notification is sent to
  the corresponding library email if it exists.
* Closes #913.
* Adds patron information for each email sent to the library emails.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: important US candidate f: circulation Concerns the circulation interface or backend f: notifications p-Medium Medium priority (to be solved within 1-2 years)
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

libraries: add notification settings in library definition AoNoOokami/rero-ils
2 participants
@iGormilhit @pronguen