Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circ_policies ui: increase API size limit #505

Closed

Conversation

zannkukai
Copy link
Contributor

Increase the default elasticsearch size result. 10000 is the maximum size for the default search type.

Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com

* Closes rero#405

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai force-pushed the ucl-#issue405-fix_api_size_limit branch from a0f92fe to d6c687e Compare September 16, 2019 16:26
@jma jma requested review from Garfield-fr, rerowep and jma September 17, 2019 05:32
@sebdeleze
Copy link

Hi, this part will be refactoring in the scope of the new angular library. Custom services for resources won't exist anymore. There will be only one service for managing API calls and you'll be able to call a method like "getRecords" which accepts the size as parameter.

For example, instead of :

this.libraryService.libraries();

You will do:

this.recordService.getRecords('libraries', [query], [page], [size]);

I think so this change is maybe not relevant.

@zannkukai zannkukai closed this Sep 17, 2019
@zannkukai
Copy link
Contributor Author

Il will continue this bug fix after Angular refactoring.

@zannkukai zannkukai deleted the ucl-#issue405-fix_api_size_limit branch September 17, 2019 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants