Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase size of result set during API calls #405

Closed
benerken opened this issue Jul 17, 2019 · 2 comments
Closed

Increase size of result set during API calls #405

benerken opened this issue Jul 17, 2019 · 2 comments
Labels
f: circulation Concerns the circulation interface or backend

Comments

@benerken
Copy link
Contributor

Release 0.2.3

We have created a test instance with :
3 organisations
22 libraries
75 locations
9 patron_types
37 item_types

In the admin screen for "circulation policies", we can choose the organisation/libraries, the patron types and the item_types but by default, the software displays ONLY the first 10 entries.
(So we are unable to configure the circ policies for all libraries, item_types or patron types.)

Capture du 2019-07-17 15-24-55

For now, it calls the APIs like this :

Capture du 2019-07-17 15-30-28

You need to increase the "default size" of APIs result sets when you get the list of libraries, items types etc...
or you could add a "size" parameter when you call the APIs
Ex: /api/item_types/ => /api/item_types/?size=100
/api/locations/ => /api/locations/?size=100

Hope it helps,
Ben & the team :-)

@benerken
Copy link
Contributor Author

It's the same behaviour when we edit an ITEM.
It lists the locations available, but only the first 30 entries.
It calls "/api/locations/?page=1&size=30&q="
=> You need to increase the size for consortium with more than 30 locations.

@lauren-d
Copy link
Contributor

lauren-d commented Aug 1, 2019

Hi,

I guess that isn't the best way but, as temporarly workaround, it's possible to modify methods in library.service.ts and item-type.service.ts files like that :

libraries() {
    return this.http.get(
      this.apiService.getApiEntryPointByType('libraries')+'?size=100',
      httpOptions
    );
  }
itemTypes() {
    return this.http.get(
      this.apiService.getApiEntryPointByType('item_types')+'?size=100',
      httpOptions
    );
  }

best,

Lauren-D
for UClouvain

zannkukai added a commit to zannkukai/rero-ils that referenced this issue Sep 16, 2019
* Closes rero#405

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Sep 16, 2019
* Closes rero#405

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Sep 17, 2019
* Closes rero#405
* use recordsService instead of specific component

run ./setup/boostrap

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Sep 18, 2019
* Closes rero#405
* use recordsService instead of specific component

run ./setup/boostrap

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Sep 18, 2019
* Closes rero#405
* use recordsService instead of specific component

run ./setup/boostrap

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Sep 18, 2019
* Closes rero#405
* use recordsService instead of specific component

run ./setup/boostrap

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Sep 18, 2019
* Closes rero#405
* use recordsService instead of specific component

run ./setup/boostrap

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Sep 19, 2019
* Closes rero#405
* use recordsService instead of specific component

run ./setup/boostrap

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Sep 20, 2019
* Closes rero#405
* use recordsService instead of specific component

run ./setup/boostrap

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Sep 23, 2019
* Closes rero#405
* use recordsService instead of specific component

run ./setup/boostrap

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Sep 25, 2019
* Closes rero#405

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Sep 25, 2019
* Closes rero#405

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Sep 30, 2019
* Closes rero#405

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Oct 1, 2019
* Closes rero#405

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Oct 1, 2019
* Closes rero#405

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@iGormilhit iGormilhit added bug f: circulation Concerns the circulation interface or backend labels Oct 2, 2019
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Oct 7, 2019
* Closes rero#405

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: circulation Concerns the circulation interface or backend
Projects
None yet
Development

No branches or pull requests

3 participants