circ_policies ui: increase API size limit #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannkukai
force-pushed
the
ucl-#issue405_fix_api_size_limit
branch
6 times, most recently
from
3e00485 to
21fdada
Compare
rerowep
requested review from
jma and
Garfield-fr
and removed request for
jma
Garfield-fr
approved these changes
Sep 25, 2019
Garfield-fr
reviewed
Sep 25, 2019
zannkukai
force-pushed
the
ucl-#issue405_fix_api_size_limit
branch
from
21fdada to
5409b7b
Compare
jma
requested changes
Sep 25, 2019
| this.itemTypeService.itemTypes(), | ||
| this.patronTypeService.patronTypes(), | ||
| this.loadAllCirculationPolicy() | ||
| this.recordsService.getRecords('global', 'item_types', 1, 9999), |
There was a problem hiding this comment.
these 9999 can be replaced by a variable or better in a configuration service (can be recordsService for the moment).
There was a problem hiding this comment.
Added 2 constants into RecordServices class : DEFAULT_REST_RESULTS_SIZE, MAX_REST_RESULTS_SIZE.
zannkukai
force-pushed
the
ucl-#issue405_fix_api_size_limit
branch
from
5409b7b to
f4c958d
Compare
jma
approved these changes
Sep 26, 2019
zannkukai
force-pushed
the
ucl-#issue405_fix_api_size_limit
branch
3 times, most recently
from
b38ec06 to
d8dbbac
Compare
* Closes rero#405 Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai
force-pushed
the
ucl-#issue405_fix_api_size_limit
branch
from
d8dbbac to
6a5a9c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com