Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

permissions: update and delete permissions api for records #760

Merged
merged 1 commit into from
Feb 17, 2020
Merged

permissions: update and delete permissions api for records #760

merged 1 commit into from
Feb 17, 2020

Conversation

BadrAly
Copy link

@BadrAly BadrAly commented Feb 17, 2020 •
edited
Loading

  • Removes update and delete permissions from document serilaizer.
  • Removes unused codes.
  • Increases test code coverage.

Co-Authored-by: Aly Badr aly.badr@rero.ch

Why are you opening this PR?

https://tree.taiga.io/project/rero21-reroils/task/1294?kanban-status=1224894

How to test?

bootstrap
record permssions API: ~/api/permissions/<resource_name>/<record_pid>/

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

@BadrAly BadrAly force-pushed the baa-new-serializer branch 2 times, most recently from 511bd5f to 75acbe1 Compare February 17, 2020 10:32
@BadrAly BadrAly added the WIP label Feb 17, 2020
@BadrAly BadrAly self-assigned this Feb 17, 2020
@Garfield-fr Garfield-fr mentioned this pull request Feb 17, 2020
Merged
7 tasks
@BadrAly BadrAly force-pushed the baa-new-serializer branch 2 times, most recently from 4c216d3 to 6ba27c1 Compare February 17, 2020 12:24
@BadrAly BadrAly added this to the v0.6.0 milestone Feb 17, 2020
@BadrAly BadrAly force-pushed the baa-new-serializer branch 3 times, most recently from 9be018c to dbf88e8 Compare February 17, 2020 12:44
@BadrAly BadrAly changed the title permissions: create a new api for records update and delete permissions permissions: update and delete permissions api for records Feb 17, 2020
@BadrAly BadrAly removed the WIP label Feb 17, 2020
jma
jma reviewed Feb 17, 2020
View reviewed changes
Copy link
Contributor

@jma jma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably do it in a cleaner manner. This can be done in a second step after the release. If this PR works we can imagine use as it for the moment.

rero_ils/modules/permissions.py Outdated Show resolved Hide resolved
rero_ils/modules/permissions.py Outdated Show resolved Hide resolved
rero_ils/modules/permissions.py Outdated Show resolved Hide resolved
rero_ils/modules/permissions.py Outdated Show resolved Hide resolved
rero_ils/modules/serializers.py Outdated Show resolved Hide resolved
@BadrAly BadrAly force-pushed the baa-new-serializer branch 2 times, most recently from 5caffdd to 8be7e92 Compare February 17, 2020 13:40
@BadrAly BadrAly requested a review from jma February 17, 2020 13:43
permissions: update and delete permissions api for records
2a6db42 
* Removes update and delete permissions from document serializer.
* Removes unused codes.
* Increases test code coverage.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
@BadrAly BadrAly merged commit d1a0c05 into rero:dev Feb 17, 2020
@BadrAly BadrAly deleted the baa-new-serializer branch November 5, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AoNoOokami AoNoOokami AoNoOokami approved these changes

@zannkukai zannkukai zannkukai approved these changes

@Garfield-fr Garfield-fr Garfield-fr approved these changes

@iGormilhit iGormilhit Awaiting requested review from iGormilhit

@jma jma Awaiting requested review from jma

Assignees

@BadrAly BadrAly

Labels
None yet
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@BadrAly @Garfield-fr @jma @zannkukai @AoNoOokami