Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix substrait issue. Fix clippy warnings. Fix pyo3 upgrade lint #2

Conversation

westonpace
Copy link

No description provided.

SaintBacchus and others added 2 commits December 2, 2024 12:20
…sk (lancedb#3183)

Now `FileFragment::create` only support create one file fragment and in
spark connector will cause these two issues:
1. if the spark task is empty, this api will have exception since there
is no data to create the fragment.
2. if the task data stream is very large, it will generate a huge file
in lance format. It is not friendly for spark parallism.

So I remove the assigned fragment id and add a new method named
`FileFragment::create_fragments` to generate empty or multi fragments.


![image](https://github.com/user-attachments/assets/54fb2497-8163-4652-9e0b-d50a88fade53)
@github-actions github-actions bot added the python label Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

@github-actions github-actions bot added the java label Dec 4, 2024
@westonpace westonpace closed this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants