Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "browsing examples" section to the Welcome Screen #3096

Closed
2 of 4 tasks
Tracked by #2695
abey79 opened this issue Aug 24, 2023 · 1 comment · Fixed by #3191
Closed
2 of 4 tasks
Tracked by #2695

Add "browsing examples" section to the Welcome Screen #3096

abey79 opened this issue Aug 24, 2023 · 1 comment · Fixed by #3191
Assignees
Labels
🎄 tracking issue issue that tracks a bunch of subissues ui concerns graphical user interface

Comments

@abey79
Copy link
Member

abey79 commented Aug 24, 2023

The "browsing examples" section is currently missing from the Welcome Screen:

image image

Goals for the first iteration

  • The example list "belongs" to the Welcome Screen (so it's available when the Welcome Screen is, which currently means "as background", when all recordings are closed).
  • Example list is built based on a hosted json file containing example metadata.
  • Only list examples for which we have a built RRD file (same as with the current demo.rerun.io).
  • Display: simple list of example summaries including title, description, tags, and thumbnail.
  • Launching an example triggers downloading the RRD from web.
  • While downloading the RRD, the existing "loading screen" shows up.

Skip for later

  • search bar UI
  • filter by tag UI
  • download progress bar

TODO

@emilk
Copy link
Member

emilk commented Aug 30, 2023

For the image loading we can use a similar strategy as I used in lampsitter/egui_commonmark#8
That is: a map of Url to PollPromise<Result<TextureHandle>>.

At some point I'd like to add proper support for this to egui, and maybe this is the point. egui could support a plugin for converting an URI to a ColorImage, and then implement the cache for that.

Here's a design for this:

@abey79 abey79 self-assigned this Sep 1, 2023
abey79 added a commit that referenced this issue Sep 6, 2023
### What

Add Example page to the Welcome Screen.


Fixes #3096 

<img width="1366" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/bbe2e84e-9ade-4da8-b095-d7b0f396c26f">

### TODO

- [x] fix layout issues
- [x] display tags
- [x] have dedicated, short copy for the description: #3201

### Not included in this PR

- **WARNING**: here, we bake in a manifest with hard-coded links to RRDs
that were generated within this PR. This will lead to issue down the
line, when the RRD format changes.
  - #3212
  - #3213
- download updated manifest
  -  #3190 
- load thumbnail from the web
  - emilk/egui#3291
- provide feedback while downloading a RRD
  - #3192

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3191) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/3191)
- [Docs
preview](https://rerun.io/preview/3be107e4cc6aa6758a3f22c27a79233b33f2ea6b/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/3be107e4cc6aa6758a3f22c27a79233b33f2ea6b/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)

---------

Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎄 tracking issue issue that tracks a bunch of subissues ui concerns graphical user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants