Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide feedback while downloading a RRD #3192

Closed
abey79 opened this issue Sep 3, 2023 · 2 comments · Fixed by #3307
Closed

Provide feedback while downloading a RRD #3192

abey79 opened this issue Sep 3, 2023 · 2 comments · Fixed by #3307
Labels
enhancement New feature or request ui concerns graphical user interface
Milestone
0.9 - Codegen, Ty...

Comments

@abey79
Copy link
Member

abey79 commented Sep 3, 2023 •
edited
Loading

There is currently no user feedback when downloading a RRD, e.g from the web via the new Example page of the Welcome Screen until at least one batch is completely read/downloaded/streamed. This is unfortunate as this state may last for a significant time for some RRD. Some feedback should be provided.
@abey79 abey79 added enhancement New feature or request ui concerns graphical user interface labels Sep 3, 2023
@abey79 abey79 mentioned this issue Sep 3, 2023
Merged
6 tasks
@abey79
Copy link
Member Author

abey79 commented Sep 5, 2023

Gigantic Slack discussion thread here: https://rerunio.slack.com/archives/C03G1SP5Y87/p1693919261107909

@abey79 abey79 changed the title Provide feedback while downloading a RRD from the web Provide feedback while downloading a RRD Sep 5, 2023
@emilk
Copy link
Member

emilk commented Sep 6, 2023

We should show all in-progress receivers in the recordings view. That is: for each receiver without a associated connection, show the receiver source.

abey79 added a commit that referenced this issue Sep 6, 2023
@abey79 @emilk
Add Examples page to the Welcome Screen (#3191)
cb197a2 
### What

Add Example page to the Welcome Screen.


Fixes #3096 

<img width="1366" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/bbe2e84e-9ade-4da8-b095-d7b0f396c26f">

### TODO

- [x] fix layout issues
- [x] display tags
- [x] have dedicated, short copy for the description: #3201

### Not included in this PR

- **WARNING**: here, we bake in a manifest with hard-coded links to RRDs
that were generated within this PR. This will lead to issue down the
line, when the RRD format changes.
  - #3212
  - #3213
- download updated manifest
  -  #3190 
- load thumbnail from the web
  - emilk/egui#3291
- provide feedback while downloading a RRD
  - #3192

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3191) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/3191)
- [Docs
preview](https://rerun.io/preview/3be107e4cc6aa6758a3f22c27a79233b33f2ea6b/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/3be107e4cc6aa6758a3f22c27a79233b33f2ea6b/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)

---------

Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
@emilk emilk mentioned this issue Sep 13, 2023
Merged
3 tasks
emilk added a commit that referenced this issue Sep 13, 2023
@emilk @Wumpf
Show currently loading recordings in Recordings menu (#3307)
43124fd 
### What
* Closes #3192

Shows currently loading receivers in the recordings panel until they
actually receive some data.

This is a blink-and-you'll-miss-it sort of thing (especially with a good
internet connection), but take a look at the top-left of the screen:


![loading-msg](https://github.com/rerun-io/rerun/assets/1148717/20e133ed-8164-4c73-9057-82ba7bfd5d8e)


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3307) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/3307)
- [Docs
preview](https://rerun.io/preview/44f7f8d87b7f656725e3eb7698eee8cd3947ecfb/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/44f7f8d87b7f656725e3eb7698eee8cd3947ecfb/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)

---------

Co-authored-by: Andreas Reich <andreas@rerun.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request ui concerns graphical user interface
Projects
None yet
Milestone
0.9 - Codegen, Type Oriented Api
Development

Successfully merging a pull request may close this issue.

Show currently loading recordings in Recordings menu rerun-io/rerun
2 participants
@emilk @abey79