Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show currently loading recordings in Recordings menu #3307

Merged
merged 8 commits into from
Sep 13, 2023
Merged

Show currently loading recordings in Recordings menu #3307

merged 8 commits into from
Sep 13, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Sep 13, 2023 •
edited by github-actions bot
Loading

What

Shows currently loading receivers in the recordings panel until they actually receive some data.

This is a blink-and-you'll-miss-it sort of thing (especially with a good internet connection), but take a look at the top-left of the screen:

loading-msg

Checklist

@emilk emilk added ui concerns graphical user interface 📺 re_viewer affects re_viewer itself labels Sep 13, 2023
@emilk emilk changed the title Emilk/loading UI Show currently loading recordings in Recordings menu Sep 13, 2023
@Wumpf Wumpf self-requested a review September 13, 2023 08:59
@Wumpf
Copy link
Member

Wumpf commented Sep 13, 2023 •
edited
Loading

image

to me it looks like the vertical spacing is unusually wide with the grid you put there 🤔, not entirely sure though

@Wumpf
Copy link
Member

Wumpf commented Sep 13, 2023

that's a super useful tooltip though, love it

Wumpf
Wumpf approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

crates/re_smart_channel/src/receive_set.rs Outdated Show resolved Hide resolved
@emilk
Copy link
Member Author

emilk commented Sep 13, 2023

Fixed:

image

@emilk emilk merged commit 43124fd into main Sep 13, 2023
@emilk emilk deleted the emilk/loading-ui branch September 13, 2023 09:38
@github-actions
Copy link

Size changes

Name main 3307/merge Change
plots.rrd 194.56 kiB 184.32 kiB -5.26%

@emilk emilk mentioned this pull request Sep 14, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
📺 re_viewer affects re_viewer itself ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide feedback while downloading a RRD
2 participants
@emilk @Wumpf