Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outlines being offset diagonally by about half a pixel #1668

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Mar 22, 2023

Fixes very subtle bug that caused outlines to be offset. With the gaps introduced in #1667 this became more quite apparent in some situations (at least if you're glued with your nose to the screen like myself ;))

Before:
image

After:
image

Note how the gap of the blue outline to the bright point in the middle is shifted in the before image - the distance is more equal in the after picture

Checklist

Fixes very subtle bug that caused outlines to be offset. With the gaps introduced in #1614 this became more quite apparent in some situations (at least if you're glued with your nose to the screen like myself ;))
@Wumpf Wumpf added the 🔺 re_renderer affects re_renderer itself label Mar 22, 2023
@Wumpf Wumpf merged commit 5e660cf into main Mar 22, 2023
@Wumpf Wumpf deleted the andreas/re_renderer/fix-outline-top-left-bias branch March 22, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔺 re_renderer affects re_renderer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants