Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outlines being offset diagonally by about half a pixel #1668

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Fix outlines being offset diagonally by about half a pixel #1668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/re_renderer/shader/composite.wgsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ var outline_voronoi_texture: texture_2d<f32>;
@fragment
fn main(in: FragmentInput) -> @location(0) Vec4 {
let resolution = Vec2(textureDimensions(color_texture).xy);
let pixel_coordinates = resolution * in.texcoord;
let pixel_coordinates = floor(resolution * in.texcoord);

// Note that we can't use a simple textureLoad using @builtin(position) here despite the lack of filtering.
// The issue is that positions provided by @builtin(position) are not dependent on the set viewport,
Expand Down
2 changes: 1 addition & 1 deletion crates/re_renderer/shader/outlines/jumpflooding_step.wgsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ var<uniform> uniforms: FrameUniformBuffer;
fn main(in: FragmentInput) -> @location(0) Vec4 {
let resolution = Vec2(textureDimensions(voronoi_texture).xy);
let pixel_step = Vec2(f32(uniforms.step_width), f32(uniforms.step_width)) / resolution;
let pixel_coordinates = resolution * in.texcoord;
let pixel_coordinates = floor(resolution * in.texcoord);

var closest_positions_a = Vec2(f32min);
var closest_distance_sq_a = f32max;
Expand Down