Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin crashes on hover #350

Closed
Lomand opened this issue Jan 23, 2022 · 2 comments · Fixed by #352
Closed

Plugin crashes on hover #350

Lomand opened this issue Jan 23, 2022 · 2 comments · Fixed by #352

Comments

@Lomand
Copy link

Lomand commented Jan 23, 2022

Repo with example
Hover over Map.add to crash the server with

>> Fatal error: Longident.flat
Fatal error: exception Misc.Fatal_error

Seems this issue will be resolved once rescript-lang/syntax#449 is merged.
cristianoc added a commit that referenced this issue Jan 24, 2022
@cristianoc
Don't crash on hover when a dependency contains lident application.
a0bb9fd 
Fixes #350

Lonident applications in types are only possible in ml, not in rescript. They might show up in the AST with OCaml dependencies.
@cristianoc cristianoc mentioned this issue Jan 24, 2022
Merged
@cristianoc
Copy link
Collaborator

@Lomand thanks for the report!
This has indeed the same cause as rescript-lang/syntax#449, however it crashes in the extension's codebase, rather than while calling the formatter.

@Lomand
Copy link
Author

Lomand commented Jan 24, 2022

Thanks a lot for the fix, Cristiano!
Really glad to hear that this issue could be resolved without relying on external repos. 🎉

cristianoc added a commit that referenced this issue Jan 24, 2022
@cristianoc
Don't crash on hover when a dependency contains lident application.
6e1a4a4 
Fixes #350

Lonident applications in types are only possible in ml, not in rescript. They might show up in the AST with OCaml dependencies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't crash on hover when a dependency contains lident application. rescript-lang/rescript-vscode
2 participants
@cristianoc @Lomand