Skip to content
This repository has been archived by the owner on Jun 15, 2023. It is now read-only.

Prevent printer from throwing when printing longident #449

Merged
merged 4 commits into from
Jun 13, 2022
Merged

Prevent printer from throwing when printing longident #449

merged 4 commits into from
Jun 13, 2022

Conversation

amiralies
Copy link
Contributor

Closes #380

IwanKaramazow
IwanKaramazow reviewed Aug 24, 2021
View reviewed changes
Copy link
Contributor

@IwanKaramazow IwanKaramazow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, just wondering if we can restructure the code to have a fast path and a slow path.

src/res_printer.ml Outdated Show resolved Hide resolved
@Lomand Lomand mentioned this pull request Jan 9, 2022
Merged
This was referenced Jan 23, 2022
Closed
Closed
@cristianoc
Copy link
Contributor

@amiralies thanks for that!
Going to merge now.

@cristianoc cristianoc merged commit 2ca03d0 into rescript-lang:master Jun 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IwanKaramazow IwanKaramazow IwanKaramazow left review comments

@cristianoc cristianoc cristianoc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fatal error when converting jscomp/test/flow_parser_reg_test.ml
3 participants
@amiralies @cristianoc @IwanKaramazow