Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Incorrect rendering about to #461

Closed
bvanjoi opened this issue Jun 16, 2022 · 3 comments · Fixed by #517
Closed

[BUG] Incorrect rendering about to #461

bvanjoi opened this issue Jun 16, 2022 · 3 comments · Fixed by #517
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@bvanjoi
Copy link

bvanjoi commented Jun 16, 2022

The weak keyword to should do not rendered after external, maybe the expected html code is <span color="red">to</span>.

image

@zth
Copy link
Collaborator

zth commented Jul 13, 2022

If we want to fix this, I guess using a semantic token forcing the identifier on the right of external to be considered a variable is the least invasive way. What do you think @cristianoc ?

@zth zth added the bug Something isn't working label Jul 13, 2022
@cristianoc
Copy link
Collaborator

cristianoc commented Jul 13, 2022

Looks like the same happens with
let to : int in interface files / module types.

Also, let foo : string has the same problem, only it is invisible. The problem is that foo is not emitted as a semantic token.

I guess the same applies insideexternal, which btw can appear in implementation of interface position identically.

@cristianoc cristianoc added help wanted Extra attention is needed good first issue Good for newcomers labels Jul 13, 2022
@cristianoc
Copy link
Collaborator

So it's about: go though semantic highlighting and identify cases where ids are not emitted and they should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants