Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Pstr_primitive to semanticTokens #517

Merged
merged 2 commits into from
Jul 25, 2022
Merged

add Pstr_primitive to semanticTokens #517

merged 2 commits into from
Jul 25, 2022

Conversation

aspeddro
Copy link
Contributor

Fix #461

cristianoc
cristianoc reviewed Jul 25, 2022
View reviewed changes
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!
Would you add the corresponding one in interface file too?

@aspeddro
Copy link
Contributor Author

Would you add the corresponding one in interface file too?

Done 4b1e518

@cristianoc cristianoc merged commit dd34759 into rescript-lang:master Jul 25, 2022
@zth
Copy link
Collaborator

zth commented Jul 25, 2022

Please try and remember adding to the changelog too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianoc cristianoc cristianoc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Incorrect rendering about to
3 participants
@aspeddro @zth @cristianoc