Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot reload forces app to become front window #1184

Closed
greatwitenorth opened this issue Jan 15, 2024 · 8 comments · Fixed by #1295
Closed

Hot reload forces app to become front window #1184

greatwitenorth opened this issue Jan 15, 2024 · 8 comments · Fixed by #1295
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@greatwitenorth
Copy link

🐞 bug report

✍️ Description

Given that I have a hot reloadable page loaded in the Responsively App, and the app is not currently the front window, when the page hot reloads, the Responsively app automatically becomes the front window, disrupting my work.

🕵🏼‍♂️ Is this a regression?

Unsure

🔬 Minimal Reproduction

  • Load a hot reloadable page in Responsively
  • Open your code editing program to the site that's currently loaded
  • Make an edit in your code and save
  • The Responsively app will automatically become the front window

🌍 Your Environment


Version: 1.10.0
Electron: 27.0.4
Chrome: 118.0.5993.129
Node.js: 18.17.1
V8: 11.8.172.17-electron.0
OS: Darwin arm64 23.1.0
@preeteshjain
Copy link

Happening with me as well. Really annoying behaviour. How can we fix this?

Possible duplicate #837

@kozleek
Copy link

kozleek commented Mar 21, 2024

Same problem here.

@jkaeske
Copy link

jkaeske commented Mar 28, 2024

Same here

@preeteshjain
Copy link

I think this is the code that is causing the issue:

} else {
mainWindow.showInactive();
if (!windowShownOnOpen) {
windowShownOnOpen = true;
mainWindow.show();
} else {
mainWindow.showInactive();
}
}
});

@ph7jack
Copy link

ph7jack commented May 30, 2024

Same issue on macOS Sonoma

@ropdias
Copy link

ropdias commented Jul 7, 2024

Same here, I agree with @preeteshjain that it's a very annoying behaviour. I'm using VSCode with Live Server. Every time I change code Responsively App get focus an open again. There should be a way to remove this behaviour in the Settings.

@jb-dev1
Copy link

jb-dev1 commented Jul 15, 2024

Same issue with MacOS Sonoma 14.5, default production download from https://responsively.app (v1.12.0, Apple Silicon) and VS Code v1.91.1 with Auto Save /afterdelay enabled.

@violetadev violetadev added bug Something isn't working help wanted Extra attention is needed labels Sep 8, 2024
@violetadev violetadev mentioned this issue Sep 8, 2024
@violetadev
Copy link
Contributor

violetadev commented Sep 8, 2024

hi there, I have opened a PR to fix this. The problem was the app kept being "ready" whenever hot reloading was triggered, making it initiate again and again, and bringing it to the front. I have fixed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants