Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1184 #1295

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Fixes #1184 #1295

merged 1 commit into from
Sep 9, 2024

Conversation

violetadev
Copy link
Contributor

✨ Pull Request

📓 Referenced Issue

Fixes: #1184
Fixes: #837

ℹ️ About the PR

This PR adds a variable to pick up when the app has been initiated, so it only comes to the front when it is being opened for the first time, but not on refresh.

🖼️ Testing Scenarios / Screenshots

STR:

  • Open the app
  • Open a page with hot loading (in this case, it's a simple html page with live server (VS code extension)
  • Make a change, the responsively app should not be focused
Screen.Recording.2024-09-09.at.01.29.46.mov

Copy link
Collaborator

@manojVivek manojVivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

So glad that you could reproduce and make a fix, I was struggling to reproduce this consistently when I tried. 🎉

@manojVivek manojVivek merged commit 2e5273d into main Sep 9, 2024
5 checks passed
@manojVivek manojVivek deleted the hot-reload-fix branch September 9, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hot reload forces app to become front window App calls focus each page refresh
2 participants