-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically manage known-common DB connections #135
Comments
nevans
added a commit
that referenced
this issue
Oct 28, 2015
Intended to be wrapped by `Throttled` config loader. n.b. if you use this, you will need to reset the redis configuration in your `after_prefork` hook. (Until #135 handles it automatically.)
nevans
added a commit
that referenced
this issue
Oct 28, 2015
Intended to be wrapped by `Throttled` config loader. n.b. if you use this, you will need to reset the redis configuration in your `after_prefork` hook. (Until #135 handles it automatically.)
This would be an awesome addition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Specifically, check for
defined? ActiveRecord::Base
andResque.redis
. Then we can remove those bits from the necessary config for probably 95% of users (and remove one of the most common misconfigurations). Any other connections will still need to be managed manually (and we will still need to document this in the README).We should do a quick search for open TCP sockets and issue a warning if any of them were shared from the master. e.g.
We could also extend this to open File, IO, UDPSocket, etc, but those are more likely to be legitimately shared between master/worker.
The text was updated successfully, but these errors were encountered: