Redis config loader #145
Open
Redis config loader #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many custom configuration loaders will retrieve the configuration from an external resource. `Resque::Pool` asks the loader for the latest configuration roughly once per second. You may want to reduce load on your external resource by caching the value, and only really fetching the latest configuration after a specific amount of time has passed. Instead of forcing each configuration loader author to re-write (and test) this logic, we provide `Resque::Pool::ConfigThrottle`. See the spec for full details of its behavior.
n.b. this cleans up the resque/pool/pooled_worker monkeypatching a little bit. It runs only on `Resque::Pool.new` now.
Intended to be wrapped by `Throttled` config loader. n.b. if you use this, you will need to reset the redis configuration in your `after_prefork` hook. (Until #135 handles it automatically.)
|
n.b. either solve #135 or clearly document that user will need to reconnect in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #144 (to not duplicate autoload/require efforts) and #142 (because this loader ought to always be wrapped in a throttling or memoized loader.
Allows basic setting/loading of configs in redis. By default it stores a separate config per app/host/env, but that can be easily changed (by choosing names that are shared among pools).