Update to TRestDetectorReadout #83
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…factoring * origin/lobis-refactoring: [pre-commit.ci] auto fixes from pre-commit.com hooks # Conflicts: # inc/TRestDetectorReadoutModule.h
for more information, see https://pre-commit.ci
jgalan
reviewed
May 31, 2023
|
I was trying to work out a solution. I think the PR should be split. For instance, I would place the |
|
In reality the classes do not need to inherit from So that we can also retrieve the children as a stand-alone metadata structure, using |
1 task
|
Closing in favour of #86 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While developing a feature request I realised the readout classes have not been worked on for a while and would benefit from some review.
The changes submitted by this PR should not alter the functionality of the classes but instead make the code more consisten with other more recently developed REST-for-Physics code and (implicit) style guidelines.