-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring TRestDetectorReadout classes. #86
Conversation
for more information, see https://pre-commit.ci
…ctorlib into jgalan-refactoring
… TransformToPlaneCoordinates.
… GetPlaneCoordinates
HI @juanangp I have added a new validation job to |
…ctorlib into jgalan-refactoring
You can change the pipeline in master to check if the pipeline suceed, this line https://github.com/rest-for-physics/framework/blob/2aae3c4346bc3914785b883438f278fc0668e358/.github/workflows/validation.yml#L645 to
This requires to make a new branch in
This is the only way that you can check if the pipeline is going to suceed, otherwise you can check after is merged, but it will not be tested in advance. We should implement submodule validation in framework in order to avoid this work around. |
Cherry-picking from PR #83 to find out the causes of pipeline failure