Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change row/column index #54

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Change row/column index #54

merged 1 commit into from
Jun 7, 2024

Conversation

taichi-ishitani
Copy link
Member

resolve rggen/rggen#210

Copy link

codeclimate bot commented Jun 7, 2024

Code Climate has analyzed commit 18e7f55 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.75%. Comparing base (617730f) to head (18e7f55).

Files Patch % Lines
...b/rggen/spreadsheet_loader/spreadsheet/position.rb 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   99.50%   99.75%   +0.25%     
==========================================
  Files          17       17              
  Lines         401      410       +9     
==========================================
+ Hits          399      409      +10     
+ Misses          2        1       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@taichi-ishitani taichi-ishitani merged commit a239a2e into master Jun 7, 2024
18 of 19 checks passed
@taichi-ishitani taichi-ishitani deleted the cell_index_value branch June 7, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XLSX input error description row/column off by one
1 participant