Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XLSX input error description row/column off by one #210

Closed
SzymonHitachi opened this issue Jun 6, 2024 · 1 comment · Fixed by rggen/rggen-spreadsheet-loader#54
Closed

XLSX input error description row/column off by one #210

SzymonHitachi opened this issue Jun 6, 2024 · 1 comment · Fixed by rggen/rggen-spreadsheet-loader#54
Assignees
@taichi-ishitani
Labels
enhancement New feature or request

Comments

@SzymonHitachi
Copy link

SzymonHitachi commented Jun 6, 2024 •
edited
Loading

Row and Columns are counted starting from 0 in rggen but in spreadsheet they are counted from 1 thus off by one error in errors printed by rggen. E.g.
[RegisterMapError] array indices are given to non-array register -- file: example.xlsx sheet: block_0 row: 30 column: 4
the actual location of the error is row 31 column E.

Additionally it would be nice if columns could use letters (names) instead of offset number.
@taichi-ishitani taichi-ishitani self-assigned this Jun 7, 2024
@taichi-ishitani taichi-ishitani added the enhancement New feature or request label Jun 7, 2024
@taichi-ishitani taichi-ishitani changed the title [bug][nitpick] XLSX input error description row/column off by one XLSX input error description row/column off by one Jun 7, 2024
taichi-ishitani added a commit to rggen/rggen-spreadsheet-loader that referenced this issue Jun 7, 2024
@taichi-ishitani
change row/column index
18e7f55 
(refs: rggen/rggen#210)
@taichi-ishitani taichi-ishitani mentioned this issue Jun 7, 2024
Merged
taichi-ishitani added a commit to rggen/rggen-spreadsheet-loader that referenced this issue Jun 7, 2024
@taichi-ishitani
change row/column index (#54, rggen/rggen#210)
a239a2e
@taichi-ishitani
Copy link
Member

Hi @SzymonHitachi ,

I just released RgGen v0.33.2.
https://rubygems.org/gems/rggen/versions/0.33.2

This release includes changes for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taichi-ishitani taichi-ishitani

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change row/column index rggen/rggen-spreadsheet-loader
2 participants
@taichi-ishitani @SzymonHitachi