RHEL-10: Fix user systemd error printed to console and other minor RDP fixes #6004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code is not used since migration to Wayland. We need another solution for this feature. (cherry picked from commit 37fa08b) Related: RHEL-67911
The GRDServer class have checks in the __init__ method which starts to complain about missing GRD in the system. That doesn't apply in Live environment where we don't support GRD in the first place. (cherry picked from commit fde3d1b) Related: RHEL-67911
(cherry picked from commit a267c32) Related: RHEL-67911
Move the GRDServer class creation to the end of the `setup_display` method. This class have checks for binaries in the `__init__` method which is causing early failures. Also do not create the class if it is not really used. (cherry picked from commit ee3c0d4) Related: RHEL-67911
Anaconda runs as an app on Live images and can hardly control remote access there. (cherry picked from commit ff77c70) Related: RHEL-67911
Previously it was vnc but we switched to RDP instead. Related: RHEL-67911
The issue with the original code is in python behavior. Python on this code: "a" or "b" will give you "b" instead of probably expected 'True' value. This is fix to avoid break of the code in the future because this variable should keep boolean value. (cherry picked from commit 56590cd) Related: RHEL-67911
Anaconda is starting systemd --user for RDP session. This unfortunately, will result in message: ``` Failed to adjust memory pressure threshold, ignoring: Device or resource busy ``` This message is printed directly to terminal and bypassing stdout or stderr. Force this message to be logged to the journal instead of terminal. Suggested-by: Lukas Nykryn (cherry picked from commit f47ca11) Resolves: RHEL-67911
jkonecny12
force-pushed
the
rhel-10-backport-rdp-fixes
branch
from
92ac0dd
to
ebf1c4f
Compare
|
/kickstart-test --testtype smoke |
|
/kickstart-test rdp_ui |
|
/kickstart-test ui_rdp |
|
Local testing done and works. |
jkonecny12
added
the
ready to merge
|
Please ignore the failed test. I made a typo in the test name so the result is not valid :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anaconda is starting systemd --user for RDP session. This unfortunately, will result in message:
This message is printed directly to terminal and bypassing stdout or stderr.
Force this message to be logged to the journal instead of terminal.
Resolves: RHEL-67911
Backport of