RHEL-10: Backport localed patchset #6000
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder, this patchset technically contains two parts:
I guess we want to split this into two but I guess we also want another RDP bug for these tweaks. Splitting shouldn't be hard to do when I was looking on the code. Also, I will fix RHEL-58834 separately (with backports of #5962 and #5979). We might add the RDP fixes into this maybe? WDYT @jstodola? RESOLVED by splitting this PR into two |
|
Converting to draft as this PR will most likely get split into two. |
The plan is to use systemd-localed to control compositor keyboard and replace current `gk_keyboard_manager`. Most of the code is in place already but we need to add a few missing ones. The most problematic is missing support for next layout. The issue is that localed service don't have support for selection, to resolve this issue we will set the first in the list as selected. However, it means that we have to keep what user has set from Anaconda so we can find next candidate when switch to next layout is requested. Keep the information when user set the layouts to the compositor. (cherry picked from commit d9ed3f7) Related: RHEL-58181
with this patch when compositor will change keyboard layout we will be able to react to that in Anaconda. This is mostly useful for Live ISO images. We have two signals currently to resolve that something has changed, one of the signals is that selected layout has changed in the compositor. The issue is that localed service doesn't have information about selected (first is taken as selected). To resolve that we need to keep values from our last query or last signal about the change so we are able to detect the change in selection. (cherry picked from commit 1b6b2c6) Resolves: RHEL-58181
Because of the switch to Wayland Anaconda has to change compositor keyboard manager because libxklavier doesn't work on Wayland. To fix that we migrated to Gnome Kiosk DBus API in RHEL-10, however, this solution can't be used outside of Gnome Kiosk. For that reason, we are switching to Localed which we set as the default to enable Anaconda to control keyboard switching. (cherry picked from commit 4dcdcf6) Resolves: RHEL-58181
This logic was used to disable keyboard switching for given system. However, we we support even Wayland systems with the new solution, so let's remove this. (cherry picked from commit cc9ad83) Related: RHEL-58181
https://fedoraproject.org/wiki/Changes/Anaconda_As_Native_Wayland_Application (cherry picked from commit 0abcdac) Related: RHEL-58181
If Anaconda will set keyboard layouts to compositor but options are missed then we shouldn't change the compositor options but rather use what is already set. This will avoid problematic behavior of changing what user has defined in the system or similar cases. Also we have this tested in kickstart-tests, so this commit is fixing these tests. Also fix existing tests and cover this functionality by tests. (cherry picked from commit e810bba) Related: RHEL-58181
jkonecny12
force-pushed
the
rhel-10-backport-wayland-patchset
branch
from
72acf9a
to
d1f442f
Compare
|
I've separated part of this change set into #6004 |
|
/kickstart-test --testtype smoke |
|
/kickstart-test --testtype coverage |
|
/kickstart-test --testtype keyboard |
|
Local testing done and passed. |
M4rtinK
approved these changes
Nov 20, 2024
jkonecny12
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport patches related to localed from #5829 to RHEL-10.
Resolves: RHEL-58181