Redirect only GLib loggers to Journal #5962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M4rtinK
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
So this seems to work well enough: A couple notes:
|
|
/kickstart-test --testtype smoke |
halfline
reviewed
Oct 24, 2024
jkonecny12
requested changes
Oct 25, 2024
jkonecny12
force-pushed
the
master-redirect_just_GTK_spam
branch
from
92c7f55
to
b5d259c
Compare
jkonecny12
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
I've updated the PR based on the suggestions above. There is still one problematic message getting into console but it's not related to this so let's resolve that in another PR. |
|
/kickstart-test --testtype smoke |
|
@M4rtinK and me decided that I'll take over this PR. So I'm removing my review. |
Previously we redirected all output from the main Anaconda process to Journal to avoid GTK log messages (as GTK runs in the main process) from spamming TTY. Turns out this broke a couple things, such as the shell prompt in rescue mode. So drop the wholesale process output redirection and instead just redirect (hopefully) all GLib based loggers (used by GTK) to Journal. Related: RHEL-58834
This place is used for all GLib imports to avoid gi.require import across the code base. Related: RHEL-58834
This is not required because we solve that on level of LogHandler which is used in this solution. Related: RHEL-58834
Do not ignore log levels from GLib when redirecting these logs to our logs. Related: RHEL-58834
jkonecny12
force-pushed
the
master-redirect_just_GTK_spam
branch
from
b5d259c
to
1b14639
Compare
jkonecny12
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
Rebased to fix the test. |
|
/kickstart-test --testtype smoke |
M4rtinK
commented
Nov 5, 2024
This was referenced Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we redirected all output from the main Anaconda process to Journal to avoid GTK log messages (as GTK runs in the main process) from spamming TTY. Turns out this broke a couple things, such as the shell prompt in rescue mode.
So drop the wholesale process output redirection and instead just redirect (hopefully) all GLib based loggers (used by GTK) to Journal.
Related: RHEL-58834